Update UnsignedDifferenceExpressionComparedZero.ql

ihsinme · web-flow · commit 69ed608a112c · 2020-12-04T09:47:11.000+03:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql b/cpp/ql/src/experimental/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql
@@ -12,11 +12,12 @@
  */
 
 import cpp
+import semmle.code.cpp.commons.Exclusions
 
 from RelationalOperation ro, SubExpr sub
 where
+  not isFromMacroDefinition(ro) and 
   ro.getLesserOperand().getValue().toInt() = 0 and
   ro.getGreaterOperand() = sub and
-  sub.getType().(IntegralType).isUnsigned()
-
-select ro , " difference in condition is always greater than or equal to zero "
+  sub.getFullyConverted().getUnspecifiedType().(IntegralType).isUnsigned()
+select ro , " difference in condition is always greater than or equal to zero " 
