Python: Port StackTraceExposure query

yoff · yoff · commit 6a45f6e7e0ea · 2021-02-09T11:12:44.000+01:00
using empty concept implementation
diff --git a/python/ql/src/Security/CWE-209/StackTraceExposure.ql b/python/ql/src/Security/CWE-209/StackTraceExposure.ql
@@ -13,19 +13,10 @@
  */
 
 import python
-import semmle.python.security.Paths
-import semmle.python.security.Exceptions
-import semmle.python.web.HttpResponse
+import semmle.python.security.dataflow.StackTraceExposure
+import DataFlow::PathGraph
 
-class StackTraceExposureConfiguration extends TaintTracking::Configuration {
-  StackTraceExposureConfiguration() { this = "Stack trace exposure configuration" }
-
-  override predicate isSource(TaintTracking::Source source) { source instanceof ErrorInfoSource }
-
-  override predicate isSink(TaintTracking::Sink sink) { sink instanceof HttpResponseTaintSink }
-}
-
-from StackTraceExposureConfiguration config, TaintedPathSource src, TaintedPathSink sink
-where config.hasFlowPath(src, sink)
-select sink.getSink(), src, sink, "$@ may be exposed to an external user", src.getSource(),
+from StackTraceExposureConfiguration config, DataFlow::PathNode source, DataFlow::PathNode sink
+where config.hasFlowPath(source, sink)
+select sink.getNode(), source, sink, "$@ may be exposed to an external user", source.getNode(),
   "Error information"
diff --git a/python/ql/src/semmle/python/security/dataflow/StackTraceExposure.qll b/python/ql/src/semmle/python/security/dataflow/StackTraceExposure.qll
@@ -0,0 +1,22 @@
+/**
+ * Provides a taint-tracking configuration for detecting SQL injection
+ * vulnerabilities.
+ */
+
+import python
+import semmle.python.dataflow.new.DataFlow
+import semmle.python.dataflow.new.TaintTracking
+import semmle.python.Concepts
+
+/**
+ * A taint-tracking configuration for detecting SQL injection vulnerabilities.
+ */
+class StackTraceExposureConfiguration extends TaintTracking::Configuration {
+  StackTraceExposureConfiguration() { this = "StackTraceExposureConfiguration" }
+
+  override predicate isSource(DataFlow::Node source) { source instanceof ErrorInfoSource }
+
+  override predicate isSink(DataFlow::Node sink) {
+    sink = any(HTTP::Server::HttpResponse response).getBody()
+  }
+}
