Shared: Clippy fixes

hmac · hmac · commit 6a8d417588d0 · 2023-04-05T18:46:57.000+08:00
Remove unnecessary borrows and lifetime specifiers.
diff --git a/shared/tree-sitter-extractor/src/diagnostics.rs b/shared/tree-sitter-extractor/src/diagnostics.rs
@@ -125,7 +125,7 @@ impl LogWriter {
                     .create(true)
                     .append(true)
                     .write(true)
-                    .open(&path)
+                    .open(path)
                 {
                     Err(e) => {
                         tracing::error!(
diff --git a/shared/tree-sitter-extractor/src/extractor.rs b/shared/tree-sitter-extractor/src/extractor.rs
@@ -123,7 +123,7 @@ pub fn extract(
     source: &[u8],
     ranges: &[Range],
 ) {
-    let path_str = file_paths::normalize_path(&path);
+    let path_str = file_paths::normalize_path(path);
     let span = tracing::span!(
         tracing::Level::TRACE,
         "extract",
@@ -137,7 +137,7 @@ pub fn extract(
     let mut parser = Parser::new();
     parser.set_language(language).unwrap();
     parser.set_included_ranges(ranges).unwrap();
-    let tree = parser.parse(&source, None).expect("Failed to parse file");
+    let tree = parser.parse(source, None).expect("Failed to parse file");
     trap_writer.comment(format!("Auto-generated TRAP file for {}", path_str));
     let file_label = populate_file(trap_writer, path);
     let mut visitor = Visitor::new(
@@ -441,7 +441,7 @@ impl<'a> Visitor<'a> {
                     "Value for unknown field: {}::{} and type {}",
                     &[
                         diagnostics::MessageArg::Code(node.kind()),
-                        diagnostics::MessageArg::Code(&child_node.field_name.unwrap_or("child")),
+                        diagnostics::MessageArg::Code(child_node.field_name.unwrap_or("child")),
                         diagnostics::MessageArg::Code(&format!("{:?}", child_node.type_name)),
                     ],
                     *node,
diff --git a/shared/tree-sitter-extractor/src/generator/dbscheme.rs b/shared/tree-sitter-extractor/src/generator/dbscheme.rs
@@ -119,7 +119,7 @@ impl<'a> fmt::Display for Union<'a> {
 }
 
 /// Generates the dbscheme by writing the given dbscheme `entries` to the `file`.
-pub fn write<'a>(file: &mut dyn std::io::Write, entries: &'a [Entry]) -> std::io::Result<()> {
+pub fn write(file: &mut dyn std::io::Write, entries: &[Entry]) -> std::io::Result<()> {
     for entry in entries {
         match entry {
             Entry::Case(case) => write!(file, "{}\n\n", case)?,
diff --git a/shared/tree-sitter-extractor/src/generator/ql.rs b/shared/tree-sitter-extractor/src/generator/ql.rs
@@ -287,7 +287,7 @@ impl<'a> fmt::Display for FormalParameter<'a> {
 }
 
 /// Generates a QL library by writing the given `elements` to the `file`.
-pub fn write<'a>(file: &mut dyn std::io::Write, elements: &'a [TopLevel]) -> std::io::Result<()> {
+pub fn write(file: &mut dyn std::io::Write, elements: &[TopLevel]) -> std::io::Result<()> {
     for element in elements {
         write!(file, "{}\n\n", &element)?;
     }

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ impl LogWriter {`
`125`	`125`	`.create(true)`
`126`	`126`	`.append(true)`
`127`	`127`	`.write(true)`
`128`		`- .open(&path)`
	`128`	`+ .open(path)`
`129`	`129`	`{`
`130`	`130`	`Err(e) => {`
`131`	`131`	`tracing::error!(`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ impl<'a> fmt::Display for Union<'a> {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	/// Generates the dbscheme by writing the given dbscheme `entries` to the `file`.
`122`		`-pub fn write<'a>(file: &mut dyn std::io::Write, entries: &'a [Entry]) -> std::io::Result<()> {`
	`122`	`+pub fn write(file: &mut dyn std::io::Write, entries: &[Entry]) -> std::io::Result<()> {`
`123`	`123`	`for entry in entries {`
`124`	`124`	`match entry {`
`125`	`125`	`Entry::Case(case) => write!(file, "{}\n\n", case)?,`
Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ impl<'a> fmt::Display for FormalParameter<'a> {`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	/// Generates a QL library by writing the given `elements` to the `file`.
`290`		`-pub fn write<'a>(file: &mut dyn std::io::Write, elements: &'a [TopLevel]) -> std::io::Result<()> {`
	`290`	`+pub fn write(file: &mut dyn std::io::Write, elements: &[TopLevel]) -> std::io::Result<()> {`
`291`	`291`	`for element in elements {`
`292`	`292`	`write!(file, "{}\n\n", &element)?;`
`293`	`293`	`}`