JS: Avoid materializing HTML::Element.getFile()

asger-semmle · asger-semmle · commit 6c0f9be6dfdc · 2019-08-30T16:02:42.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Vue.qll b/javascript/ql/src/semmle/javascript/frameworks/Vue.qll
@@ -352,7 +352,8 @@ module Vue {
     }
 
     private Module getModule() {
-      exists(HTML::ScriptElement elem | elem.getFile() = file |
+      exists(HTML::ScriptElement elem |
+        xmlElements(elem, _, _, _, file) and // Avoid materializing all of Locatable.getFile()
         result.getTopLevel() = elem.getScript()
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,8 @@ module Vue {`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`private Module getModule() {`
`355`		`- exists(HTML::ScriptElement elem \| elem.getFile() = file \|`
	`355`	`+ exists(HTML::ScriptElement elem \|`
	`356`	`+ xmlElements(elem, _, _, _, file) and // Avoid materializing all of Locatable.getFile()`
`356`	`357`	`result.getTopLevel() = elem.getScript()`
`357`	`358`	`)`
`358`	`359`	`}`