Make DefaultCase include NullDefaultCase

smowton · smowton · commit 6e868d21bd08 · 2023-11-30T11:24:03.000Z
diff --git a/java/ql/lib/semmle/code/java/Expr.qll b/java/ql/lib/semmle/code/java/Expr.qll
@@ -1535,7 +1535,7 @@ class SwitchExpr extends Expr, StmtParent, @switchexpr {
    *
    * Note this may be `default` or `case null, default`.
    */
-  SwitchCase getDefaultCase() { result = this.getACase() and result.hasDefaultLabel() }
+  DefaultCase getDefaultCase() { result = this.getACase() }
 
   /** Gets the expression of this `switch` expression. */
   Expr getExpr() { result.getParent() = this }
@@ -1738,9 +1738,7 @@ class LocalVariableDeclExpr extends Expr, @localvariabledeclexpr {
 
 /** A local variable declaration that occurs within a record pattern. */
 class RecordBindingVariableExpr extends LocalVariableDeclExpr {
-  RecordBindingVariableExpr() {
-    this.getParent() instanceof RecordPatternExpr
-  }
+  RecordBindingVariableExpr() { this.getParent() instanceof RecordPatternExpr }
 }
 
 /** An update of a variable or an initialization of the variable. */
diff --git a/java/ql/lib/semmle/code/java/Statement.qll b/java/ql/lib/semmle/code/java/Statement.qll
@@ -408,7 +408,7 @@ class SwitchStmt extends Stmt, @switchstmt {
    *
    * Note this may be `default` or `case null, default`.
    */
-  SwitchCase getDefaultCase() { result = this.getACase() and result.hasDefaultLabel() }
+  DefaultCase getDefaultCase() { result = this.getACase() }
 
   /** Gets the expression of this `switch` statement. */
   Expr getExpr() { result.getParent() = this }
@@ -492,12 +492,6 @@ class SwitchCase extends Stmt, @case {
   Stmt getRuleStatementOrExpressionStatement() {
     result.getParent() = this and result.getIndex() = -1
   }
-
-  /**
-   * Holds if this case statement includes the default label, i.e. it is either `default`
-   * or `case null, default`.
-   */
-  predicate hasDefaultLabel() { this instanceof DefaultCase or this instanceof NullDefaultCase }
 }
 
 /**
@@ -553,12 +547,14 @@ class PatternCase extends SwitchCase {
 }
 
 /**
- * A `default` case of a `switch` statement.
- *
- * Note this does not include `case null, default` -- for that, see `NullDefaultCase`.
+ * A `default` or `case null, default` case of a `switch` statement or expression.
  */
 class DefaultCase extends SwitchCase {
-  DefaultCase() { not exists(Expr e | e.getParent() = this | e.getIndex() >= 0) }
+  DefaultCase() {
+    isNullDefaultCase(this)
+    or
+    not exists(Expr e | e.getParent() = this | e.getIndex() >= 0)
+  }
 
   override string pp() { result = "default" }
 
@@ -570,7 +566,7 @@ class DefaultCase extends SwitchCase {
 }
 
 /** A `case null, default` statement of a `switch` statement or expression. */
-class NullDefaultCase extends SwitchCase {
+class NullDefaultCase extends DefaultCase {
   NullDefaultCase() { isNullDefaultCase(this) }
 
   override string pp() { result = "case null, default" }
diff --git a/java/ql/lib/semmle/code/java/controlflow/internal/GuardsLogic.qll b/java/ql/lib/semmle/code/java/controlflow/internal/GuardsLogic.qll
@@ -55,11 +55,11 @@ predicate implies_v1(Guard g1, boolean b1, Guard g2, boolean b2) {
     )
   )
   or
-  exists(SwitchCase sc | g1 = sc and sc.hasDefaultLabel() |
+  exists(DefaultCase sc | g1 = sc |
     sc.getSwitch().getAConstCase() = g2 and b1 = true and b2 = false
   )
   or
-  exists(SwitchCase sc | g1 = sc and sc.hasDefaultLabel() |
+  exists(DefaultCase sc | g1 = sc |
     sc.getSwitchExpr().getAConstCase() = g2 and b1 = true and b2 = false
   )
   or
diff --git a/java/ql/lib/semmle/code/java/metrics/MetricCallable.qll b/java/ql/lib/semmle/code/java/metrics/MetricCallable.qll
@@ -78,9 +78,7 @@ private predicate branchingSwitchCase(ConstCase sc) {
 }
 
 private predicate defaultFallThrough(ConstCase sc) {
-  exists(SwitchCase default | default.hasDefaultLabel() |
-    default.(ControlFlowNode).getASuccessor() = sc
-  )
+  exists(DefaultCase default | default.(ControlFlowNode).getASuccessor() = sc)
   or
   defaultFallThrough(sc.(ControlFlowNode).getAPredecessor())
 }

Original file line number	Diff line number	Diff line change
`@@ -55,11 +55,11 @@ predicate implies_v1(Guard g1, boolean b1, Guard g2, boolean b2) {`
`55`	`55`	`)`
`56`	`56`	`)`
`57`	`57`	`or`
`58`		`- exists(SwitchCase sc \| g1 = sc and sc.hasDefaultLabel() \|`
	`58`	`+ exists(DefaultCase sc \| g1 = sc \|`
`59`	`59`	`sc.getSwitch().getAConstCase() = g2 and b1 = true and b2 = false`
`60`	`60`	`)`
`61`	`61`	`or`
`62`		`- exists(SwitchCase sc \| g1 = sc and sc.hasDefaultLabel() \|`
	`62`	`+ exists(DefaultCase sc \| g1 = sc \|`
`63`	`63`	`sc.getSwitchExpr().getAConstCase() = g2 and b1 = true and b2 = false`
`64`	`64`	`)`
`65`	`65`	`or`
Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ private predicate branchingSwitchCase(ConstCase sc) {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`private predicate defaultFallThrough(ConstCase sc) {`
`81`		`- exists(SwitchCase default \| default.hasDefaultLabel() \|`
`82`		`- default.(ControlFlowNode).getASuccessor() = sc`
`83`		`- )`
	`81`	`+ exists(DefaultCase default \| default.(ControlFlowNode).getASuccessor() = sc)`
`84`	`82`	`or`
`85`	`83`	`defaultFallThrough(sc.(ControlFlowNode).getAPredecessor())`
`86`	`84`	`}`