JS: Do not flag void operands MissingAwait

asgerf · asgerf · commit 77105f657263 · 2020-02-19T09:30:03.000Z
diff --git a/javascript/ql/src/Expressions/MissingAwait.ql b/javascript/ql/src/Expressions/MissingAwait.ql
@@ -43,7 +43,10 @@ predicate isBadPromiseContext(Expr expr) {
   or
   expr = any(LogicalBinaryExpr e).getLeftOperand()
   or
-  expr = any(UnaryExpr e).getOperand()
+  exists(UnaryExpr e |
+    expr = e.getOperand() and
+    not e instanceof VoidExpr
+  )
   or
   expr = any(UpdateExpr e).getOperand()
   or
diff --git a/javascript/ql/test/query-tests/Expressions/MissingAwait/tst.js b/javascript/ql/test/query-tests/Expressions/MissingAwait/tst.js
@@ -61,3 +61,7 @@ function useThingPossiblySync(b) {
 
     return thing + "bar"; // NOT OK - but we don't flag it
 }
+
+function useThingInVoid() {
+    void getThing(); // OK
+}

Original file line number	Diff line number	Diff line change
`@@ -61,3 +61,7 @@ function useThingPossiblySync(b) {`
`61`	`61`
`62`	`62`	`return thing + "bar"; // NOT OK - but we don't flag it`
`63`	`63`	`}`
	`64`	`+`
	`65`	`+function useThingInVoid() {`
	`66`	`+ void getThing(); // OK`
	`67`	`+}`