Fix test to correctly highlight lack of flow from field init

atorralba · atorralba · commit 775b53b7b4b3 · 2022-05-20T12:36:10.000+02:00
diff --git a/java/ql/test/kotlin/library-tests/field-initializer-flow/test.expected b/java/ql/test/kotlin/library-tests/field-initializer-flow/test.expected
@@ -1,4 +1,3 @@
 isFinalField
 | test.kt:3:3:3:18 | x |
-#select
-| test.kt:3:3:3:18 | this.x | test.kt:6:10:6:10 | getX(...) |
+#select
diff --git a/java/ql/test/kotlin/library-tests/field-initializer-flow/test.ql b/java/ql/test/kotlin/library-tests/field-initializer-flow/test.ql
@@ -4,9 +4,7 @@ import semmle.code.java.dataflow.DataFlow
 class Config extends DataFlow::Configuration {
   Config() { this = "Config" }
 
-  override predicate isSource(DataFlow::Node n) {
-    n.asExpr().(CompileTimeConstantExpr).getStringValue() = "Source"
-  }
+  override predicate isSource(DataFlow::Node n) { n.asExpr().(StringLiteral).getValue() = "Source" }
 
   override predicate isSink(DataFlow::Node n) {
     n.asExpr().(Argument).getCall().getCallee().getName() = "sink"
