JS: Add JSDoc name resolution test

asger-semmle · asger-semmle · commit 7d2e83710a35 · 2019-07-23T17:14:56.000+01:00
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/bar.js b/javascript/ql/test/library-tests/JSDoc/NameResolution/bar.js
@@ -0,0 +1,8 @@
+function test() {
+  let x = ns.very.long.namespace;
+
+  /**
+   * @param {x.Foo} foo
+   */
+  function f(foo) {}
+}
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/closure.js b/javascript/ql/test/library-tests/JSDoc/NameResolution/closure.js
@@ -0,0 +1,13 @@
+goog.module('test');
+
+let net = goog.require('goog.net');
+
+let { SomeType } = net;
+
+/**
+ * @param {goog.net.SomeType} xio 
+ * @param {net.SomeType} xio2 
+ * @param {SomeType} xio3
+ */
+function test(xio, xio2, xio3) {
+}
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/foo.js b/javascript/ql/test/library-tests/JSDoc/NameResolution/foo.js
@@ -0,0 +1,3 @@
+ns = ns || {};
+
+ns.very.long.namespace.Foo = class {};
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/test.expected b/javascript/ql/test/library-tests/JSDoc/NameResolution/test.expected
@@ -0,0 +1,4 @@
+| bar.js:5:14:5:18 | x.Foo | ns.very.long.namespace.Foo |
+| closure.js:8:12:8:28 | goog.net.SomeType | goog.net.SomeType |
+| closure.js:9:12:9:23 | net.SomeType | goog.net.SomeType |
+| closure.js:10:12:10:19 | SomeType | goog.net.SomeType |
diff --git a/javascript/ql/test/library-tests/JSDoc/NameResolution/test.ql b/javascript/ql/test/library-tests/JSDoc/NameResolution/test.ql
@@ -0,0 +1,5 @@
+import javascript
+
+query string test_hasQualifiedName(JSDocNamedTypeExpr expr) {
+  expr.hasQualifiedName(result)
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+ns = ns \|\| {};`
	`2`	`+`
	`3`	`+ns.very.long.namespace.Foo = class {};`