Python: Add getLocation to EssaVariable.

tausbn · tausbn · commit 817a142abc20 · 2021-01-29T14:45:12.000+01:00
This may be a slightly "bogus" location to provide for ESSA variables,
but it can be useful for debugging. For instance, where previously you
might just see

```
SSA variable x | ...
SSA variable x | ...
SSA variable x | ...
SSA variable x | ...
SSA variable x | ...
SSA variable x | ...
```

where each instance of `SSA variable x` was just a bare string, now
each occurrence will tell you (via its location) _where_ this variable
is being (re)defined.
diff --git a/python/ql/src/semmle/python/essa/Essa.qll b/python/ql/src/semmle/python/essa/Essa.qll
@@ -61,6 +61,13 @@ class EssaVariable extends TEssaDefinition {
    * defined by `from ... import *` and the like.
    */
   predicate isMetaVariable() { this.getName() = "$" }
+
+  /**
+   * Gets the location of this variable.
+   *
+   * Yields the location of the corresponding definition of this variable.
+   */
+  Location getLocation() { result = this.getDefinition().getLocation() }
 }
 
 /*
