JS: Treat GeneratedCodeExpr as DirectEval in UnusedVariable.ql

asgerf · asgerf · commit 8a50d99f3357 · 2021-08-11T12:36:35.000+02:00
diff --git a/javascript/ql/src/Declarations/UnusedVariable.ql b/javascript/ql/src/Declarations/UnusedVariable.ql
@@ -167,7 +167,7 @@ predicate whitelisted(UnusedLocal v) {
     vd.isAmbient()
   )
   or
-  exists(DirectEval eval |
+  exists(Expr eval | eval instanceof DirectEval or eval instanceof GeneratedCodeExpr |
     // eval nearby
     eval.getEnclosingFunction() = v.getADeclaration().getEnclosingFunction() and
     // ... but not on the RHS

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ predicate whitelisted(UnusedLocal v) {`
`167`	`167`	`vd.isAmbient()`
`168`	`168`	`)`
`169`	`169`	`or`
`170`		`- exists(DirectEval eval \|`
	`170`	`+ exists(Expr eval \| eval instanceof DirectEval or eval instanceof GeneratedCodeExpr \|`
`171`	`171`	`// eval nearby`
`172`	`172`	`eval.getEnclosingFunction() = v.getADeclaration().getEnclosingFunction() and`
`173`	`173`	`// ... but not on the RHS`