Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 94a828a

Browse files
yoffyoff
committed
Merge branch 'master' of github.com:github/codeql into SharedDataflow
To avoid CodeScan check failing
2 parents b65e6fb + 71665a0 commit 94a828a

217 files changed

Lines changed: 13315 additions & 8788 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/codeql/codeql-config.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
name: "CodeQL config"
2+
3+
queries:
4+
- uses: security-and-quality

‎.github/workflows/codeql-analysis.yml‎

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
name: "Code scanning - action"
2+
3+
on:
4+
push:
5+
pull_request:
6+
schedule:
7+
- cron: '0 9 * * 1'
8+
9+
jobs:
10+
CodeQL-Build:
11+
12+
runs-on: ubuntu-latest
13+
14+
steps:
15+
- name: Checkout repository
16+
uses: actions/checkout@v2
17+
with:
18+
# We must fetch at least the immediate parents so that if this is
19+
# a pull request then we can checkout the head.
20+
fetch-depth: 2
21+
22+
# If this run was triggered by a pull request event, then checkout
23+
# the head of the pull request instead of the merge commit.
24+
- run: git checkout HEAD^2
25+
if: ${{ github.event_name == 'pull_request' }}
26+
27+
# Initializes the CodeQL tools for scanning.
28+
- name: Initialize CodeQL
29+
uses: github/codeql-action/init@v1
30+
# Override language selection by uncommenting this and choosing your languages
31+
with:
32+
languages: csharp
33+
config-file: ./.github/codeql/codeql-config.yml
34+
35+
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
36+
# If this step fails, then you should remove it and run the build manually (see below)
37+
- name: Autobuild
38+
uses: github/codeql-action/autobuild@v1
39+
40+
# ℹ️ Command-line programs to run using the OS shell.
41+
# 📚 https://git.io/JvXDl
42+
43+
# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
44+
# and modify them (or add more) to build your code if your project
45+
# uses a compiled language
46+
47+
#- run: |
48+
# make bootstrap
49+
# make release
50+
51+
- name: Perform CodeQL Analysis
52+
uses: github/codeql-action/analyze@v1

‎change-notes/1.25/analysis-javascript.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
| Hard-coded credentials (`js/hardcoded-credentials`) | More results | This query now recognizes hard-coded credentials sent via HTTP authorization headers. |
4747
| Incomplete URL scheme check (`js/incomplete-url-scheme-check`) | More results | This query now recognizes additional url scheme checks. |
4848
| Misspelled variable name (`js/misspelled-variable-name`) | Message changed | The message for this query now correctly identifies the misspelled variable in additional cases. |
49+
| Non-linear pattern (`js/non-linear-pattern`) | Fewer duplicates and message changed | This query now generates fewer duplicate alerts and has a clearer explanation in case of type annotations used in a pattern. |
4950
| Prototype pollution in utility function (`js/prototype-pollution-utility`) | More results | This query now recognizes additional utility functions as vulnerable to prototype polution. |
5051
| Uncontrolled command line (`js/command-line-injection`) | More results | This query now recognizes additional command execution calls. |
5152
| Uncontrolled data used in path expression (`js/path-injection`) | More results | This query now recognizes additional file system calls. |

‎config/identical-files.json‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,18 @@
101101
"cpp/ql/src/semmle/code/cpp/ir/implementation/UseSoundEscapeAnalysis.qll",
102102
"csharp/ql/src/experimental/ir/implementation/UseSoundEscapeAnalysis.qll"
103103
],
104+
"IR IRFunctionBase": [
105+
"cpp/ql/src/semmle/code/cpp/ir/implementation/internal/IRFunctionBase.qll",
106+
"csharp/ql/src/experimental/ir/implementation/internal/IRFunctionBase.qll"
107+
],
104108
"IR Operand Tag": [
105109
"cpp/ql/src/semmle/code/cpp/ir/implementation/internal/OperandTag.qll",
106110
"csharp/ql/src/experimental/ir/implementation/internal/OperandTag.qll"
107111
],
112+
"IR TInstruction":[
113+
"cpp/ql/src/semmle/code/cpp/ir/implementation/internal/TInstruction.qll",
114+
"csharp/ql/src/experimental/ir/implementation/internal/TInstruction.qll"
115+
],
108116
"IR TIRVariable":[
109117
"cpp/ql/src/semmle/code/cpp/ir/implementation/internal/TIRVariable.qll",
110118
"csharp/ql/src/experimental/ir/implementation/internal/TIRVariable.qll"
@@ -182,6 +190,11 @@
182190
"cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/IRBlockImports.qll",
183191
"cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/IRBlockImports.qll"
184192
],
193+
"C++ IR IRFunctionImports": [
194+
"cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/IRFunctionImports.qll",
195+
"cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/IRFunctionImports.qll",
196+
"cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/IRFunctionImports.qll"
197+
],
185198
"C++ IR IRVariableImports": [
186199
"cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/IRVariableImports.qll",
187200
"cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/IRVariableImports.qll",
@@ -292,6 +305,10 @@
292305
"csharp/ql/src/experimental/ir/implementation/raw/internal/IRBlockImports.qll",
293306
"csharp/ql/src/experimental/ir/implementation/unaliased_ssa/internal/IRBlockImports.qll"
294307
],
308+
"C# IR IRFunctionImports": [
309+
"csharp/ql/src/experimental/ir/implementation/raw/internal/IRFunctionImports.qll",
310+
"csharp/ql/src/experimental/ir/implementation/unaliased_ssa/internal/IRFunctionImports.qll"
311+
],
295312
"C# IR IRVariableImports": [
296313
"csharp/ql/src/experimental/ir/implementation/raw/internal/IRVariableImports.qll",
297314
"csharp/ql/src/experimental/ir/implementation/unaliased_ssa/internal/IRVariableImports.qll"

‎cpp/ql/src/Likely Bugs/RedundantNullCheckSimple.ql‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import semmle.code.cpp.ir.ValueNumbering
2323
class NullInstruction extends ConstantValueInstruction {
2424
NullInstruction() {
2525
this.getValue() = "0" and
26-
this.getResultType().getUnspecifiedType() instanceof PointerType
26+
this.getResultIRType() instanceof IRAddressType
2727
}
2828
}
2929

@@ -44,8 +44,8 @@ predicate explicitNullTestOfInstruction(Instruction checked, Instruction bool) {
4444
bool =
4545
any(ConvertInstruction convert |
4646
checked = convert.getUnary() and
47-
convert.getResultType() instanceof BoolType and
48-
checked.getResultType() instanceof PointerType
47+
convert.getResultIRType() instanceof IRBooleanType and
48+
checked.getResultIRType() instanceof IRAddressType
4949
)
5050
}
5151

‎cpp/ql/src/codeql-suites/cpp-code-scanning.qls‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@
22
- qlpack: codeql-cpp
33
- apply: code-scanning-selectors.yml
44
from: codeql-suite-helpers
5+
- apply: codeql-suites/exclude-slow-queries.yml
6+
from: codeql-cpp

‎cpp/ql/src/codeql-suites/cpp-lgtm-full.qls‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,8 @@
22
- qlpack: codeql-cpp
33
- apply: lgtm-selectors.yml
44
from: codeql-suite-helpers
5-
# These queries are infeasible to compute on large projects:
6-
- exclude:
7-
query path:
8-
- Security/CWE/CWE-497/ExposedSystemData.ql
9-
- Critical/DescriptorMayNotBeClosed.ql
10-
- Critical/DescriptorNeverClosed.ql
11-
- Critical/FileMayNotBeClosed.ql
12-
- Critical/FileNeverClosed.ql
13-
- Critical/MemoryMayNotBeFreed.ql
14-
- Critical/MemoryNeverFreed.ql
5+
- apply: codeql-suites/exclude-slow-queries.yml
6+
from: codeql-cpp
157
# These are only for IDE use.
168
- exclude:
179
tags contain:

‎cpp/ql/src/codeql-suites/cpp-security-and-quality.qls‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
- description: Security-and-quality queries for C and C++
2+
- qlpack: codeql-cpp
3+
- apply: security-and-quality-selectors.yml
4+
from: codeql-suite-helpers
5+
- apply: codeql-suites/exclude-slow-queries.yml
6+
from: codeql-cpp

‎cpp/ql/src/codeql-suites/cpp-security-extended.qls‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
- description: Security-extended queries for C and C++
2+
- qlpack: codeql-cpp
3+
- apply: security-extended-selectors.yml
4+
from: codeql-suite-helpers
5+
- apply: codeql-suites/exclude-slow-queries.yml
6+
from: codeql-cpp

‎cpp/ql/src/codeql-suites/exclude-slow-queries.yml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
- description: C/C++ queries which are infeasible to compute on large projects
2+
# These queries are infeasible to compute on large projects:
3+
- exclude:
4+
query path:
5+
- Security/CWE/CWE-497/ExposedSystemData.ql
6+
- Critical/DescriptorMayNotBeClosed.ql
7+
- Critical/DescriptorNeverClosed.ql
8+
- Critical/FileMayNotBeClosed.ql
9+
- Critical/FileNeverClosed.ql
10+
- Critical/MemoryMayNotBeFreed.ql
11+
- Critical/MemoryNeverFreed.ql

0 commit comments

Comments
 (0)