fixed bad SourceNode X SourceNode join in HTTP model

erik-krogh · erik-krogh · commit 956311457db8 · 2021-04-08T21:15:50.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Express.qll b/javascript/ql/src/semmle/javascript/frameworks/Express.qll
@@ -688,8 +688,7 @@ module Express {
     override RouteHandler getRouteHandler() { result = rh }
 
     override Expr getNameExpr() {
-      exists(DataFlow::PropWrite write |
-        getAHeaderSource().flowsTo(write.getBase()) and
+      exists(DataFlow::PropWrite write | getAHeaderSource().getAPropertyWrite() = write |
         result = write.getPropertyNameExpr()
       )
     }
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Fastify.qll b/javascript/ql/src/semmle/javascript/frameworks/Fastify.qll
@@ -283,8 +283,7 @@ module Fastify {
     override RouteHandler getRouteHandler() { result = rh }
 
     override Expr getNameExpr() {
-      exists(DataFlow::PropWrite write |
-        this.getAHeaderSource().flowsTo(write.getBase()) and
+      exists(DataFlow::PropWrite write | getAHeaderSource().getAPropertyWrite() = write |
         result = write.getPropertyNameExpr()
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -688,8 +688,7 @@ module Express {`
`688`	`688`	`override RouteHandler getRouteHandler() { result = rh }`
`689`	`689`
`690`	`690`	`override Expr getNameExpr() {`
`691`		`- exists(DataFlow::PropWrite write \|`
`692`		`- getAHeaderSource().flowsTo(write.getBase()) and`
	`691`	`+ exists(DataFlow::PropWrite write \| getAHeaderSource().getAPropertyWrite() = write \|`
`693`	`692`	`result = write.getPropertyNameExpr()`
`694`	`693`	`)`
`695`	`694`	`}`
Original file line number	Diff line number	Diff line change
`@@ -283,8 +283,7 @@ module Fastify {`
`283`	`283`	`override RouteHandler getRouteHandler() { result = rh }`
`284`	`284`
`285`	`285`	`override Expr getNameExpr() {`
`286`		`- exists(DataFlow::PropWrite write \|`
`287`		`- this.getAHeaderSource().flowsTo(write.getBase()) and`
	`286`	`+ exists(DataFlow::PropWrite write \| getAHeaderSource().getAPropertyWrite() = write \|`
`288`	`287`	`result = write.getPropertyNameExpr()`
`289`	`288`	`)`
`290`	`289`	`}`