improve printing of JS object literals

erik-krogh · erik-krogh · commit a0193129535a · 2020-10-15T11:47:45.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/PrintAst.qll b/javascript/ql/src/semmle/javascript/PrintAst.qll
@@ -224,14 +224,24 @@ private module PrintJavaScript {
      */
     private string repr(ASTNode a) {
       shouldPrint(a, _) and
-      exists(DeclStmt decl | decl = a |
-        result =
-          getDeclarationKeyword(decl) + " " +
-            strictconcat(string name, int i |
-              name = decl.getDecl(i).getBindingPattern().getName()
-            |
-              name, ", " order by i
-            ) + " = ..."
+      (
+        exists(DeclStmt decl | decl = a |
+          result =
+            getDeclarationKeyword(decl) + " " +
+              strictconcat(string name, int i |
+                name = decl.getDecl(i).getBindingPattern().getName()
+              |
+                name, ", " order by i
+              ) + " = ..."
+        )
+        or
+        exists(ObjectExpr obj | obj = a | result = "{" + obj.getProperty(0).getName() + ": ...}")
+        or
+        result = a.(Property).getName() + ": " + repr(a.(Property).getInit())
+        or
+        result = a.(Literal).getRawValue()
+        or
+        result = a.(Identifier).getName()
       )
     }
 
