Apply suggestions from code review

atorralba · atorralba · commit a046d75ea68c · 2021-08-04T13:15:49.000+02:00
diff --git a/java/ql/src/Security/CWE/CWE-347/MissingJWTSignatureCheck.ql b/java/ql/src/Security/CWE/CWE-347/MissingJWTSignatureCheck.ql
@@ -1,6 +1,6 @@
 /**
  * @name Missing JWT signature check
- * @description Failing to check the JWT signature may allow an attacker to forge their own tokens.
+ * @description Failing to check the Json Web Token (JWT) signature may allow an attacker to forge their own tokens.
  * @kind path-problem
  * @problem.severity error
  * @security-severity 7.8
diff --git a/java/ql/src/semmle/code/java/dataflow/ExternalFlow.qll b/java/ql/src/semmle/code/java/dataflow/ExternalFlow.qll
@@ -97,7 +97,6 @@ private module Frameworks {
   private import semmle.code.java.security.ResponseSplitting
   private import semmle.code.java.security.InformationLeak
   private import semmle.code.java.security.JexlInjectionSinkModels
-  private import semmle.code.java.security.JWT
   private import semmle.code.java.security.LdapInjection
   private import semmle.code.java.security.XPath
   private import semmle.code.java.frameworks.android.SQLite
diff --git a/java/ql/src/semmle/code/java/security/JWT.qll b/java/ql/src/semmle/code/java/security/JWT.qll
@@ -1,4 +1,4 @@
-/** Provides classes for working with JWT libraries. */
+/** Provides classes for working with JSON Web Token (JWT) libraries. */
 
 import java
 private import semmle.code.java.dataflow.ExternalFlow
diff --git a/java/ql/src/semmle/code/java/security/MissingJWTSignatureCheckQuery.qll b/java/ql/src/semmle/code/java/security/MissingJWTSignatureCheckQuery.qll
@@ -1,8 +1,7 @@
-/** Provides classes to be used in queries related to JWT signature vulnerabilities. */
+/** Provides classes to be used in queries related to JSON Web Token (JWT) signature vulnerabilities. */
 
 import java
 import semmle.code.java.dataflow.DataFlow
-import semmle.code.java.dataflow.ExternalFlow
 import semmle.code.java.security.JWT
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/** Provides classes for working with JWT libraries. */`
	`1`	`+/** Provides classes for working with JSON Web Token (JWT) libraries. */`
`2`	`2`
`3`	`3`	`import java`
`4`	`4`	`private import semmle.code.java.dataflow.ExternalFlow`