Reduce false alarms of InconsistentNullnessTesting.ql

codeqlhelper · web-flow · commit af2a7eadc39c · 2024-04-09T00:07:40.000+08:00
We should ignore `checked` in a macro to avoid too many false alarms,
diff --git a/cpp/ql/src/Critical/InconsistentNullnessTesting.ql b/cpp/ql/src/Critical/InconsistentNullnessTesting.ql
@@ -15,6 +15,8 @@ import cpp
 from StackVariable v, ControlFlowNode def, VariableAccess checked, VariableAccess unchecked
 where
   checked = v.getAnAccess() and
+  // The check can often be in a macro for handling exception
+  not checked.isInMacroExpansion() and
   dereferenced(checked) and
   unchecked = v.getAnAccess() and
   dereferenced(unchecked) and
