update {rb/js/java}/unused-parameter to match python

erik-krogh · erik-krogh · commit b471a401cc7d · 2022-08-22T21:41:45.000+02:00
diff --git a/java/ql/src/DeadCode/UselessParameter.ql b/java/ql/src/DeadCode/UselessParameter.ql
@@ -14,4 +14,4 @@ import semmle.code.java.deadcode.DeadCode
 
 from RootdefCallable c
 where not c.whitelisted()
-select c.unusedParameter() as p, "The parameter " + p + " is unused."
+select c.unusedParameter() as p, "The parameter '" + c + "' is never used."
diff --git a/javascript/ql/src/Declarations/UnusedParameter.ql b/javascript/ql/src/Declarations/UnusedParameter.ql
@@ -13,4 +13,4 @@ import UnusedParameter
 
 from Parameter p
 where isAnAccidentallyUnusedParameter(p)
-select p, "Unused parameter " + p.getAVariable().getName() + "."
+select p, "The parameter '" + p.getVariable().getName() + "' is never used."
diff --git a/ruby/ql/src/queries/variables/UnusedParameter.ql b/ruby/ql/src/queries/variables/UnusedParameter.ql
@@ -24,4 +24,4 @@ class RelevantParameterVariable extends LocalVariable {
 
 from RelevantParameterVariable v
 where not exists(Ssa::WriteDefinition def | def.getWriteAccess() = v.getDefiningAccess())
-select v, "Unused parameter."
+select v, "The parameter '" + v.getName() + "' is never used."
