Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit b812518

Browse files
erik-krogherik-krogh
authored
Merge pull request #9716 from erik-krogh/htmlTypeSan
JS: sanitize non-strings from html-constructed-from-input
2 parents 677f6da + 112caa3 commit b812518

5 files changed

Lines changed: 48 additions & 17 deletions

File tree

‎javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,6 +1126,19 @@ module TaintTracking {
11261126
)
11271127
}
11281128

1129+
/** A test for the value of `typeof x`, restricting the potential types of `x`. */
1130+
predicate isStringTypeGuard(EqualityTest test, Expr operand, boolean polarity) {
1131+
exists(TypeofTag tag | TaintTracking::isTypeofGuard(test, operand, tag) |
1132+
// typeof x === "string" sanitizes `x` when it evaluates to false
1133+
tag = "string" and
1134+
polarity = test.getPolarity().booleanNot()
1135+
or
1136+
// typeof x === "object" sanitizes `x` when it evaluates to true
1137+
tag != "string" and
1138+
polarity = test.getPolarity()
1139+
)
1140+
}
1141+
11291142
/** Holds if `guard` is a test that checks if `operand` is a number. */
11301143
predicate isNumberGuard(DataFlow::Node guard, Expr operand, boolean polarity) {
11311144
exists(DataFlow::CallNode isNaN |

‎javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeHtmlConstructionCustomizations.qll‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,4 +180,18 @@ module UnsafeHtmlConstruction {
180180

181181
override string describe() { result = "Markdown rendering" }
182182
}
183+
184+
/** A test for the value of `typeof x`, restricting the potential types of `x`. */
185+
class TypeTestGuard extends TaintTracking::SanitizerGuardNode, DataFlow::ValueNode {
186+
override EqualityTest astNode;
187+
Expr operand;
188+
boolean polarity;
189+
190+
TypeTestGuard() { TaintTracking::isStringTypeGuard(astNode, operand, polarity) }
191+
192+
override predicate sanitizes(boolean outcome, Expr e) {
193+
polarity = outcome and
194+
e = operand
195+
}
196+
}
183197
}

‎javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomQuery.qll‎

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
import javascript
7-
private import semmle.javascript.dataflow.InferredTypes
87
private import XssThroughDomCustomizations::XssThroughDom
98
private import semmle.javascript.security.dataflow.DomBasedXssCustomizations
109
private import semmle.javascript.security.dataflow.UnsafeJQueryPluginCustomizations::UnsafeJQueryPlugin as UnsafeJQuery
@@ -52,27 +51,13 @@ class Configuration extends TaintTracking::Configuration {
5251
}
5352
}
5453

55-
/**
56-
* A test of form `typeof x === "something"`, preventing `x` from being a string in some cases.
57-
*
58-
* This sanitizer helps prune infeasible paths in type-overloaded functions.
59-
*/
54+
/** A test for the value of `typeof x`, restricting the potential types of `x`. */
6055
class TypeTestGuard extends TaintTracking::SanitizerGuardNode, DataFlow::ValueNode {
6156
override EqualityTest astNode;
6257
Expr operand;
6358
boolean polarity;
6459

65-
TypeTestGuard() {
66-
exists(TypeofTag tag | TaintTracking::isTypeofGuard(astNode, operand, tag) |
67-
// typeof x === "string" sanitizes `x` when it evaluates to false
68-
tag = "string" and
69-
polarity = astNode.getPolarity().booleanNot()
70-
or
71-
// typeof x === "object" sanitizes `x` when it evaluates to true
72-
tag != "string" and
73-
polarity = astNode.getPolarity()
74-
)
75-
}
60+
TypeTestGuard() { TaintTracking::isStringTypeGuard(astNode, operand, polarity) }
7661

7762
override predicate sanitizes(boolean outcome, Expr e) {
7863
polarity = outcome and

‎javascript/ql/test/query-tests/Security/CWE-079/UnsafeHtmlConstruction/UnsafeHtmlConstruction.expected‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ nodes
4646
| main.js:66:35:66:41 | attrVal |
4747
| main.js:67:63:67:69 | attrVal |
4848
| main.js:67:63:67:69 | attrVal |
49+
| main.js:79:34:79:36 | val |
50+
| main.js:79:34:79:36 | val |
51+
| main.js:81:35:81:37 | val |
52+
| main.js:81:35:81:37 | val |
4953
| typed.ts:1:39:1:39 | s |
5054
| typed.ts:1:39:1:39 | s |
5155
| typed.ts:2:29:2:29 | s |
@@ -107,6 +111,10 @@ edges
107111
| main.js:66:35:66:41 | attrVal | main.js:67:63:67:69 | attrVal |
108112
| main.js:66:35:66:41 | attrVal | main.js:67:63:67:69 | attrVal |
109113
| main.js:66:35:66:41 | attrVal | main.js:67:63:67:69 | attrVal |
114+
| main.js:79:34:79:36 | val | main.js:81:35:81:37 | val |
115+
| main.js:79:34:79:36 | val | main.js:81:35:81:37 | val |
116+
| main.js:79:34:79:36 | val | main.js:81:35:81:37 | val |
117+
| main.js:79:34:79:36 | val | main.js:81:35:81:37 | val |
110118
| typed.ts:1:39:1:39 | s | typed.ts:2:29:2:29 | s |
111119
| typed.ts:1:39:1:39 | s | typed.ts:2:29:2:29 | s |
112120
| typed.ts:1:39:1:39 | s | typed.ts:2:29:2:29 | s |
@@ -132,5 +140,6 @@ edges
132140
| main.js:47:65:47:73 | this.step | main.js:52:41:52:41 | s | main.js:47:65:47:73 | this.step | $@ based on $@ might later cause $@. | main.js:47:65:47:73 | this.step | HTML construction | main.js:52:41:52:41 | s | library input | main.js:47:54:47:85 | "<span> ... /span>" | cross-site scripting |
133141
| main.js:62:19:62:31 | settings.name | main.js:56:28:56:34 | options | main.js:62:19:62:31 | settings.name | $@ based on $@ might later cause $@. | main.js:62:19:62:31 | settings.name | HTML construction | main.js:56:28:56:34 | options | library input | main.js:62:11:62:40 | "<b>" + ... "</b>" | cross-site scripting |
134142
| main.js:67:63:67:69 | attrVal | main.js:66:35:66:41 | attrVal | main.js:67:63:67:69 | attrVal | $@ based on $@ might later cause $@. | main.js:67:63:67:69 | attrVal | HTML construction | main.js:66:35:66:41 | attrVal | library input | main.js:67:47:67:78 | "<img a ... "\\"/>" | cross-site scripting |
143+
| main.js:81:35:81:37 | val | main.js:79:34:79:36 | val | main.js:81:35:81:37 | val | $@ based on $@ might later cause $@. | main.js:81:35:81:37 | val | HTML construction | main.js:79:34:79:36 | val | library input | main.js:81:24:81:49 | "<span> ... /span>" | cross-site scripting |
135144
| typed.ts:2:29:2:29 | s | typed.ts:1:39:1:39 | s | typed.ts:2:29:2:29 | s | $@ based on $@ might later cause $@. | typed.ts:2:29:2:29 | s | HTML construction | typed.ts:1:39:1:39 | s | library input | typed.ts:3:31:3:34 | html | cross-site scripting |
136145
| typed.ts:8:40:8:40 | s | typed.ts:6:43:6:43 | s | typed.ts:8:40:8:40 | s | $@ based on $@ might later cause $@. | typed.ts:8:40:8:40 | s | HTML construction | typed.ts:6:43:6:43 | s | library input | typed.ts:8:29:8:52 | "<span> ... /span>" | cross-site scripting |

‎javascript/ql/test/query-tests/Security/CWE-079/UnsafeHtmlConstruction/main.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,13 @@ module.exports.intentionalTemplate = function (obj) {
7575
const html = "<span>" + obj.spanTemplate + "</span>"; // OK
7676
document.querySelector("#template").innerHTML = html;
7777
}
78+
79+
module.exports.types = function (val) {
80+
if (typeof val === "string") {
81+
$("#foo").html("<span>" + val + "</span>"); // NOT OK
82+
} else if (typeof val === "number") {
83+
$("#foo").html("<span>" + val + "</span>"); // OK
84+
} else if (typeof val === "boolean") {
85+
$("#foo").html("<span>" + val + "</span>"); // OK
86+
}
87+
}

0 commit comments

Comments
 (0)