Java: Rewrite most telemetry queries to restrict the number of produced results.

michaelnebel · michaelnebel · commit b9b4aedd0315 · 2022-06-15T10:59:12.000+02:00
diff --git a/java/ql/src/Telemetry/SupportedExternalSinks.ql b/java/ql/src/Telemetry/SupportedExternalSinks.ql
@@ -10,13 +10,16 @@ import java
 import ExternalApi
 import semmle.code.java.GeneratedFiles
 
-from ExternalApi api, int usages
-where
+private predicate getRelevantUsages(ExternalApi api, int usages) {
   not api.isUninteresting() and
   api.isSink() and
   usages =
     strictcount(Call c |
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
+}
+
+from ExternalApi api, int usages
+where Results<getRelevantUsages/2>::restrict(api, usages)
 select api.getApiName() as apiname, usages order by usages desc
diff --git a/java/ql/src/Telemetry/SupportedExternalSources.ql b/java/ql/src/Telemetry/SupportedExternalSources.ql
@@ -10,13 +10,16 @@ import java
 import ExternalApi
 import semmle.code.java.GeneratedFiles
 
-from ExternalApi api, int usages
-where
+private predicate getRelevantUsages(ExternalApi api, int usages) {
   not api.isUninteresting() and
   api.isSource() and
   usages =
     strictcount(Call c |
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
+}
+
+from ExternalApi api, int usages
+where Results<getRelevantUsages/2>::restrict(api, usages)
 select api.getApiName() as apiname, usages order by usages desc
diff --git a/java/ql/src/Telemetry/SupportedExternalTaint.ql b/java/ql/src/Telemetry/SupportedExternalTaint.ql
@@ -10,13 +10,16 @@ import java
 import ExternalApi
 import semmle.code.java.GeneratedFiles
 
-from ExternalApi api, int usages
-where
+private predicate getRelevantUsages(ExternalApi api, int usages) {
   not api.isUninteresting() and
   api.hasSummary() and
   usages =
     strictcount(Call c |
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
+}
+
+from ExternalApi api, int usages
+where Results<getRelevantUsages/2>::restrict(api, usages)
 select api.getApiName() as apiname, usages order by usages desc
diff --git a/java/ql/src/Telemetry/UnsupportedExternalAPIs.ql b/java/ql/src/Telemetry/UnsupportedExternalAPIs.ql
@@ -10,13 +10,16 @@ import java
 import ExternalApi
 import semmle.code.java.GeneratedFiles
 
-from ExternalApi api, int usages
-where
+private predicate getRelevantUsages(ExternalApi api, int usages) {
   not api.isUninteresting() and
   not api.isSupported() and
   usages =
     strictcount(Call c |
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
+}
+
+from ExternalApi api, int usages
+where Results<getRelevantUsages/2>::restrict(api, usages)
 select api.getApiName() as apiname, usages order by usages desc
