Ruby: Don't classify our test files as test files

hmac · hmac · commit b9d15bacba6a · 2023-11-27T09:17:59.000Z
For model editing purposes.
diff --git a/ruby/ql/src/utils/modeleditor/ModelEditor.qll b/ruby/ql/src/utils/modeleditor/ModelEditor.qll
@@ -132,7 +132,10 @@ string methodClassification(Call method) {
 }
 
 class TestFile extends File {
-  TestFile() { this.getRelativePath().regexpMatch(".*(test|spec).+") }
+  TestFile() {
+    this.getRelativePath().regexpMatch(".*(test|spec).+") and
+    not this.getAbsolutePath().matches("%/ql/test/%") // allows our test cases to work
+  }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,10 @@ string methodClassification(Call method) {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`class TestFile extends File {`
`135`		`- TestFile() { this.getRelativePath().regexpMatch(".*(test\|spec).+") }`
	`135`	`+ TestFile() {`
	`136`	`+ this.getRelativePath().regexpMatch(".*(test\|spec).+") and`
	`137`	`+ not this.getAbsolutePath().matches("%/ql/test/%") // allows our test cases to work`
	`138`	`+ }`
`136`	`139`	`}`
`137`	`140`
`138`	`141`	`/**`