CPP: Add a test of ODASA-3654.

geoffw0 · geoffw0 · commit bd138238b0b4 · 2019-03-26T12:37:32.000Z
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Format/WrongNumberOfFormatArguments/WrongNumberOfFormatArguments.expected b/cpp/ql/test/query-tests/Likely Bugs/Format/WrongNumberOfFormatArguments/WrongNumberOfFormatArguments.expected
@@ -6,3 +6,4 @@
 | test.c:15:2:15:7 | call to printf | Format expects 3 arguments but given 2 |
 | test.c:19:2:19:7 | call to printf | Format expects 2 arguments but given 1 |
 | test.c:29:3:29:8 | call to printf | Format expects 2 arguments but given 1 |
+| test.c:44:2:44:7 | call to printf | Format expects 3 arguments but given 2 |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Format/WrongNumberOfFormatArguments/test.c b/cpp/ql/test/query-tests/Likely Bugs/Format/WrongNumberOfFormatArguments/test.c
@@ -40,4 +40,6 @@ void test(int i, const char *str)
 		printf("%2$.*4$f", 0, num, 0, precision); // GOOD [FALSE POSITIVE]
 		printf("%2$.*4$f", num, 0, precision); // BAD (too few format arguments) [INCORRECT MESSAGE]
 	}
+
+	printf("%@ %i %i", 1, 2); // GOOD [FALSE POSITIVE]
 }

Original file line number	Diff line number	Diff line change
`@@ -40,4 +40,6 @@ void test(int i, const char *str)`
`40`	`40`	`printf("%2$.*4$f", 0, num, 0, precision); // GOOD [FALSE POSITIVE]`
`41`	`41`	`printf("%2$.*4$f", num, 0, precision); // BAD (too few format arguments) [INCORRECT MESSAGE]`
`42`	`42`	`}`
	`43`	`+`
	`44`	`+ printf("%@ %i %i", 1, 2); // GOOD [FALSE POSITIVE]`
`43`	`45`	`}`