Apply suggestions from code review

tiferet · Stephan Brandauer · web-flow · commit c0aae3d68ecb · 2022-12-02T09:00:45.000-08:00
Co-authored-by: Stephan Brandauer &lt;kaeluka@github.com&gt;
diff --git a/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/ATMConfig.qll b/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/ATMConfig.qll
@@ -159,7 +159,7 @@ abstract class AtmConfig extends JS::TaintTracking::Configuration {
    * Holds if if `sink` is an effective sink with flow from `source` which gets used as a sink candidate for scoring
    * with the ML model.
    */
-  predicate isSinkCandidate(JS::DataFlow::PathNode sink) {
+  predicate isSinkCandidateWithFlow(JS::DataFlow::Node sink) {
     exists(JS::DataFlow::PathNode source |
       this.hasFlowPath(source, sink) and
       not AtmResultsInfo::isFlowLikelyInBaseQuery(source.getNode(), sink.getNode())
diff --git a/javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_large_scale/ExtractEndpointDataInference.ql b/javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_large_scale/ExtractEndpointDataInference.ql
@@ -23,5 +23,5 @@ private import experimental.adaptivethreatmodeling.XssThroughDomATM as XssThroug
 query predicate isSinkCandidateForQuery(
   AtmConfig::AtmConfig queryConfig, JS::DataFlow::PathNode sink
 ) {
-  queryConfig.isSinkCandidate(sink)
+  queryConfig.isSinkCandidateWithFlow(sink)
 }

Original file line number	Diff line number	Diff line change
`@@ -23,5 +23,5 @@ private import experimental.adaptivethreatmodeling.XssThroughDomATM as XssThroug`
`23`	`23`	`query predicate isSinkCandidateForQuery(`
`24`	`24`	`AtmConfig::AtmConfig queryConfig, JS::DataFlow::PathNode sink`
`25`	`25`	`) {`
`26`		`- queryConfig.isSinkCandidate(sink)`
	`26`	`+ queryConfig.isSinkCandidateWithFlow(sink)`
`27`	`27`	`}`