Lang3 StrBuilder: fix typo and coding style

smowton · smowton · commit c243e0313391 · 2021-02-17T09:50:56.000Z
diff --git a/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll b/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll
@@ -144,7 +144,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai
   }
 
   private predicate consumesTaintFromAllArgs() {
-    // Specifically the append[ln](String, Object...) overloads also consume taint from its other arguments:
+    // Specifically the append[ln](String, Object...) overloads also consume taint from their other arguments:
     this.getName() in ["appendAll", "appendWithSeparators"]
     or
     this.getName() = ["append", "appendln"] and this.getAParameter().isVarargs()
@@ -167,7 +167,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai
         else fromArg = 1
       )
       or
-      consumesTaintFromAllArgs() and fromArg in [0 .. this.getNumberOfParameters() - 1]
+      this.consumesTaintFromAllArgs() and fromArg in [0 .. this.getNumberOfParameters() - 1]
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`private predicate consumesTaintFromAllArgs() {`
`147`		`- // Specifically the append[ln](String, Object...) overloads also consume taint from its other arguments:`
	`147`	`+ // Specifically the append[ln](String, Object...) overloads also consume taint from their other arguments:`
`148`	`148`	`this.getName() in ["appendAll", "appendWithSeparators"]`
`149`	`149`	`or`
`150`	`150`	`this.getName() = ["append", "appendln"] and this.getAParameter().isVarargs()`
`@@ -167,7 +167,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai`
`167`	`167`	`else fromArg = 1`
`168`	`168`	`)`
`169`	`169`	`or`
`170`		`- consumesTaintFromAllArgs() and fromArg in [0 .. this.getNumberOfParameters() - 1]`
	`170`	`+ this.consumesTaintFromAllArgs() and fromArg in [0 .. this.getNumberOfParameters() - 1]`
`171`	`171`	`)`
`172`	`172`	`}`
`173`	`173`	`}`