Python: ObjectAPI to ValueAPI: OverlyComplexDelMethod: Adds preliminary modernization

BekaValentine · BekaValentine · commit c2443f2342a2 · 2020-04-07T21:31:35.000-07:00
diff --git a/python/ql/src/Functions/OverlyComplexDelMethod.ql b/python/ql/src/Functions/OverlyComplexDelMethod.ql
@@ -15,10 +15,10 @@
 
 import python
 
-from FunctionObject method
+from FunctionValue method
 where
-    exists(ClassObject c |
+    exists(ClassValue c |
         c.declaredAttribute("__del__") = method and
-        method.getFunction().getMetrics().getCyclomaticComplexity() > 3
+        method.getScope().getMetrics().getCyclomaticComplexity() > 3
     )
 select method, "Overly complex '__del__' method."
diff --git a/python/ql/test/query-tests/Functions/general/OverlyComplexDelMethod.expected b/python/ql/test/query-tests/Functions/general/OverlyComplexDelMethod.expected
@@ -1 +1 @@
-| protocols.py:74:5:74:22 | Function __del__ | Overly complex '__del__' method. |
+| protocols.py:74:5:74:22 | Function MegaDel.__del__ | Overly complex '__del__' method. |

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-\| protocols.py:74:5:74:22 \| Function __del__ \| Overly complex '__del__' method. \|`
	`1`	`+\| protocols.py:74:5:74:22 \| Function MegaDel.__del__ \| Overly complex '__del__' method. \|`