C++: Remove StdStringBeginEnd

Robert Marsh · Robert Marsh · commit c8cdf68bf9b8 · 2020-09-08T13:49:57.000-07:00
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Iterator.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Iterator.qll
@@ -272,6 +272,10 @@ class IteratorArrayMemberOperator extends MemberFunction, TaintFunction {
   }
 }
 
+/**
+ * A `begin` or `end` member function, or a related member function, that
+ * returns an iterator.
+ */
 class BeginOrEndFunction extends MemberFunction, TaintFunction {
   BeginOrEndFunction() {
     this.hasName(["begin", "cbegin", "rbegin", "crbegin", "end", "cend", "rend", "crend"]) and
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/StdString.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/StdString.qll
@@ -212,23 +212,6 @@ class StdStringAssign extends TaintFunction {
   }
 }
 
-/**
- * The standard functions `std::string.begin` and `std::string.end` and their
- * variants.
- */
-class StdStringBeginEnd extends TaintFunction {
-  StdStringBeginEnd() {
-    this
-        .hasQualifiedName("std", "basic_string",
-          ["begin", "cbegin", "rbegin", "crbegin", "end", "cend", "rend", "crend"])
-  }
-
-  override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
-    input.isQualifierObject() and
-    output.isReturnValue()
-  }
-}
-
 /**
  * The standard function `std::string.copy`.
  */

Original file line number	Diff line number	Diff line change
`@@ -272,6 +272,10 @@ class IteratorArrayMemberOperator extends MemberFunction, TaintFunction {`
`272`	`272`	`}`
`273`	`273`	`}`
`274`	`274`
	`275`	`+/**`
	`276`	+ * A `begin` or `end` member function, or a related member function, that
	`277`	`+ * returns an iterator.`
	`278`	`+ */`
`275`	`279`	`class BeginOrEndFunction extends MemberFunction, TaintFunction {`
`276`	`280`	`BeginOrEndFunction() {`
`277`	`281`	`this.hasName(["begin", "cbegin", "rbegin", "crbegin", "end", "cend", "rend", "crend"]) and`