Apply suggestions from code review

JLLeitschuh · Marcono1234 · JLLeitschuh · commit d0b0b767a28d · 2021-05-11T10:36:47.000-04:00
Co-authored-by: Marcono1234 &lt;Marcono1234@users.noreply.github.com&gt;
diff --git a/java/ql/src/semmle/code/java/frameworks/jackson/JacksonSerializability.qll b/java/ql/src/semmle/code/java/frameworks/jackson/JacksonSerializability.qll
@@ -75,7 +75,7 @@ private class ExplicitlyWrittenJacksonSerializableType extends JacksonSerializab
 private class ExplicitlyReadJacksonSerializableType extends JacksonDeserializableType {
   ExplicitlyReadJacksonSerializableType() {
     exists(MethodAccess ma |
-      // A call to a Jackson write method...
+      // A call to a Jackson read method...
       ma.getMethod() instanceof JacksonReadValueMethod and
       // ...where `this` is used in the final argument, indicating that this type will be deserialized.
       usesType(ma.getArgument(ma.getNumArgument() - 1).getType(), this)
@@ -126,8 +126,8 @@ private class ExplicitlyReadJacksonDeserializableType extends JacksonDeserializa
 }
 
 /** A type used in a `JacksonDeserializableField` declaration. */
-private class FieldReferencedJacksonDeSerializableType extends JacksonDeserializableType {
-  FieldReferencedJacksonDeSerializableType() {
+private class FieldReferencedJacksonDeserializableType extends JacksonDeserializableType {
+  FieldReferencedJacksonDeserializableType() {
     exists(JacksonDeserializableField f | usesType(f.getType(), this))
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ private class ExplicitlyWrittenJacksonSerializableType extends JacksonSerializab`
`75`	`75`	`private class ExplicitlyReadJacksonSerializableType extends JacksonDeserializableType {`
`76`	`76`	`ExplicitlyReadJacksonSerializableType() {`
`77`	`77`	`exists(MethodAccess ma \|`
`78`		`- // A call to a Jackson write method...`
	`78`	`+ // A call to a Jackson read method...`
`79`	`79`	`ma.getMethod() instanceof JacksonReadValueMethod and`
`80`	`80`	// ...where `this` is used in the final argument, indicating that this type will be deserialized.
`81`	`81`	`usesType(ma.getArgument(ma.getNumArgument() - 1).getType(), this)`
`@@ -126,8 +126,8 @@ private class ExplicitlyReadJacksonDeserializableType extends JacksonDeserializa`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	/** A type used in a `JacksonDeserializableField` declaration. */
`129`		`-private class FieldReferencedJacksonDeSerializableType extends JacksonDeserializableType {`
`130`		`- FieldReferencedJacksonDeSerializableType() {`
	`129`	`+private class FieldReferencedJacksonDeserializableType extends JacksonDeserializableType {`
	`130`	`+ FieldReferencedJacksonDeserializableType() {`
`131`	`131`	`exists(JacksonDeserializableField f \| usesType(f.getType(), this))`
`132`	`132`	`}`
`133`	`133`	`}`