fixed pr suggestions for tags/formatting

dilanbhalla · dilanbhalla · commit d201c4ba8ad6 · 2020-07-07T09:34:04.000-07:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-359/PrivateCleartextBufferWrite.ql b/cpp/ql/src/experimental/Security/CWE/CWE-359/PrivateCleartextBufferWrite.ql
@@ -4,7 +4,6 @@
  *              to an attacker.
  * @kind path-problem
  * @problem.severity warning
- * @precision medium
  * @id cpp/private-cleartext-storage-buffer
  * @tags security
  *       external/cwe/cwe-312
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-359/PrivateCleartextFileWrite.ql b/cpp/ql/src/experimental/Security/CWE/CWE-359/PrivateCleartextFileWrite.ql
@@ -4,7 +4,6 @@
  *              to an attacker.
  * @kind problem
  * @problem.severity warning
- * @precision medium
  * @id cpp/private-cleartext-storage-file
  * @tags security
  *       external/cwe/cwe-313
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-359/PrivateCleartextStorage.qhelp b/cpp/ql/src/experimental/Security/CWE/CWE-359/PrivateCleartextStorage.qhelp
@@ -19,6 +19,7 @@ cleartext.</p>
 
 <references>
 
+<li><a href="https://owasp.org/www-project-top-ten/OWASP_Top_Ten_2017/Top_10-2017_A3-Sensitive_Data_Exposure">OWASP Sensitive_Data_Exposure</a>
 <li>M. Dowd, J. McDonald and J. Schuhm, <i>The Art of Software Security Assessment</i>, 1st Edition, Chapter 2 - 'Common Vulnerabilities of Encryption', p. 43. Addison Wesley, 2006.</li> 
 <li>M. Howard and D. LeBlanc, <i>Writing Secure Code</i>, 2nd Edition, Chapter 9 - 'Protecting Secret Data', p. 299. Microsoft, 2002.</li>
 
diff --git a/cpp/ql/src/experimental/semmle/code/cpp/security/PrivateData.qll b/cpp/ql/src/experimental/semmle/code/cpp/security/PrivateData.qll
@@ -51,4 +51,3 @@ class PrivateVariableAccess extends PrivateDataExpr, VariableAccess {
     exists(string s | this.getTarget().getName().toLowerCase() = s | s.matches(privateNames()))
   }
 }
-

Original file line number	Diff line number	Diff line change
`@@ -51,4 +51,3 @@ class PrivateVariableAccess extends PrivateDataExpr, VariableAccess {`
`51`	`51`	`exists(string s \| this.getTarget().getName().toLowerCase() = s \| s.matches(privateNames()))`
`52`	`52`	`}`
`53`	`53`	`}`
`54`		`-`