Python: Value::forString and friends returns StringValue

RasmusWL · RasmusWL · commit d30e6d2b692d · 2020-02-03T14:35:09.000+01:00
diff --git a/python/ql/src/semmle/python/objects/ObjectAPI.qll b/python/ql/src/semmle/python/objects/ObjectAPI.qll
@@ -256,23 +256,23 @@ module Value {
      * There will be no `Value` for most byte strings, unless it is explicitly
      * declared in the source program.
      */
-    Value forBytes(string bytes) {
+    StringValue forBytes(string bytes) {
         result.(BytesObjectInternal).strValue() = bytes
     }
 
     /** Gets the `Value` for the unicode constant `text`, if it exists.
      * There will be no `Value` for most text strings, unless it is explicitly
      * declared in the source program.
      */
-    Value forUnicode(string text) {
+    StringValue forUnicode(string text) {
         result.(UnicodeObjectInternal).strValue() = text
     }
 
     /** Gets a `Value` for the string `text`. May be a bytes or unicode string for Python 2.
      * There will be no `Value` for most strings, unless it is explicitly
      * declared in the source program.
      */
-    Value forString(string text) {
+    StringValue forString(string text) {
         result.(UnicodeObjectInternal).strValue() = text
         or
         major_version() = 2 and
