Merge pull request #2646 from geoffw0/modelinet

jbj · web-flow · commit d3a185679369 · 2020-01-17T22:53:43.000+01:00
CPP: Fix a mistake in Inet.qll.
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Inet.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Inet.qll
@@ -47,7 +47,7 @@ class InetNetwork extends TaintFunction, ArrayFunction {
   InetNetwork() { hasGlobalName("inet_network") }
 
   override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
-    input.isParameterDeref(1) and
+    input.isParameterDeref(0) and
     output.isReturnValue()
   }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class InetNetwork extends TaintFunction, ArrayFunction {`
`47`	`47`	`InetNetwork() { hasGlobalName("inet_network") }`
`48`	`48`
`49`	`49`	`override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {`
`50`		`- input.isParameterDeref(1) and`
	`50`	`+ input.isParameterDeref(0) and`
`51`	`51`	`output.isReturnValue()`
`52`	`52`	`}`
`53`	`53`