CPP: Correct the ConditionallyUninitializedVariable examples.

geoffw0 · geoffw0 · commit d693eb8c20a1 · 2019-10-28T17:39:45.000Z
diff --git a/cpp/ql/src/Security/CWE/CWE-457/ConditionallyUninitializedVariableBad.c b/cpp/ql/src/Security/CWE/CWE-457/ConditionallyUninitializedVariableBad.c
@@ -19,7 +19,7 @@ int notify(int deviceNumber) {
   DeviceConfig config;
   initDeviceConfig(&config, deviceNumber);
   // BAD: Using config without checking the status code that is returned
-  if (config->isEnabled) {
-    notifyChannel(config->channel);
+  if (config.isEnabled) {
+    notifyChannel(config.channel);
   }
-}
+}
diff --git a/cpp/ql/src/Security/CWE/CWE-457/ConditionallyUninitializedVariableGood.c b/cpp/ql/src/Security/CWE/CWE-457/ConditionallyUninitializedVariableGood.c
@@ -20,8 +20,8 @@ void notify(int deviceNumber) {
   int statusCode = initDeviceConfig(&config, deviceNumber);
   if (statusCode == 0) {
     // GOOD: Status code returned by initialization function is checked, so this is safe
-    if (config->isEnabled) {
-      notifyChannel(config->channel);
+    if (config.isEnabled) {
+      notifyChannel(config.channel);
     }
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@ void notify(int deviceNumber) {`
`20`	`20`	`int statusCode = initDeviceConfig(&config, deviceNumber);`
`21`	`21`	`if (statusCode == 0) {`
`22`	`22`	`// GOOD: Status code returned by initialization function is checked, so this is safe`
`23`		`- if (config->isEnabled) {`
`24`		`- notifyChannel(config->channel);`
	`23`	`+ if (config.isEnabled) {`
	`24`	`+ notifyChannel(config.channel);`
`25`	`25`	`}`
`26`	`26`	`}`
`27`		`-}`
	`27`	`+}`