Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d976168

Browse files
authored
Merge pull request #328 from hvitved/mergeback-2018-10-17
Approved by adityasharad, xiemaisi
2 parents f2663d4 + 58a0815 commit d976168

753 files changed

Lines changed: 29842 additions & 24323 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Improvements to C# analysis
2+
3+
## General improvements
4+
5+
* The control flow graph construction now takes simple Boolean conditions on local scope variables into account. For example, in `if (b) x = 0; if (b) x = 1;`, the control flow graph will reflect that taking the `true` (resp. `false`) branch in the first condition implies taking the same branch in the second condition. In effect, the first assignment to `x` will now be identified as being dead.
6+
7+
## New queries
8+
9+
| **Query** | **Tags** | **Purpose** |
10+
|-----------------------------|-----------|--------------------------------------------------------------------|
11+
| *@name of query (Query ID)* | *Tags* |*Aim of the new query and whether it is enabled by default or not* |
12+
13+
## Changes to existing queries
14+
15+
| **Query** | **Expected impact** | **Change** |
16+
|----------------------------|------------------------|------------------------------------------------------------------|
17+
| *@name of query (Query ID)*| *Impact on results* | *How/why the query has changed* |
18+
19+
20+
## Changes to QL libraries

change-notes/1.19/analysis-javascript.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
* Support for popular libraries has been improved. Consequently, queries may produce more results on code bases that use the following features:
1010
- file system access, for example through [fs-extra](https://github.com/jprichardson/node-fs-extra) or [globby](https://www.npmjs.com/package/globby)
11+
- outbound network access, for example through the [fetch API](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API)
12+
- the [Google Cloud Spanner](https://cloud.google.com/spanner) database
1113

1214
* The type inference now handles nested imports (that is, imports not appearing at the toplevel). This may yield fewer false-positive results on projects that use this non-standard language feature.
1315

@@ -33,6 +35,7 @@
3335
| Remote property injection | Fewer results | The precision of this rule has been revised to "medium". Results are no longer shown on LGTM by default. |
3436
| Missing CSRF middleware | Fewer false-positive results | This rule now recognizes additional CSRF protection middlewares. |
3537
| Server-side URL redirect | More results | This rule now recognizes redirection calls in more cases. |
38+
| User-controlled bypass of security check | Fewer results | This rule no longer flags conditions that guard early returns. The precision of this rule has been revised to "medium". Results are no longer shown on LGTM by default. |
3639
| Whitespace contradicts operator precedence | Fewer false-positive results | This rule no longer flags operators with asymmetric whitespace. |
3740

3841
## Changes to QL libraries

cpp/ql/src/Likely Bugs/Arithmetic/UnsignedGEZero.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,6 @@ predicate unsignedGEZero(UnsignedGEZero ugez, string msg) {
5050
ugez.getLocation().getStartLine() = mi.getLocation().getStartLine() and
5151
ugez.getLocation().getStartColumn() = mi.getLocation().getStartColumn()
5252
) and
53+
not ugez.isFromTemplateInstantiation(_) and
5354
msg = "Pointless comparison of unsigned value to zero."
5455
}

cpp/ql/src/Likely Bugs/OO/NonVirtualDestructor.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* @id cpp/non-virtual-destructor
88
* @problem.severity warning
99
* @tags reliability
10+
* @deprecated
1011
*/
1112

1213
// This query is deprecated, and replaced by jsf/4.10 Classes/AV Rule 78.ql, which has far fewer false positives on typical code.

0 commit comments

Comments
 (0)