CPP: Simplify to 'CrementOperation'.

geoffw0 · geoffw0 · commit db6e2904a863 · 2019-06-25T14:17:20.000+01:00
diff --git a/cpp/ql/src/Likely Bugs/Leap Year/LeapYear.qll b/cpp/ql/src/Likely Bugs/Leap Year/LeapYear.qll
@@ -59,8 +59,7 @@ abstract class LeapYearFieldAccess extends YearFieldAccess {
       (
         op instanceof AssignArithmeticOperation or
         exists(BinaryArithmeticOperation bao | bao = op.getAnOperand()) or
-        op instanceof PostfixCrementOperation or
-        op instanceof PrefixCrementOperation
+        op instanceof CrementOperation
       )
     )
   }
@@ -117,9 +116,7 @@ abstract class LeapYearFieldAccess extends YearFieldAccess {
           )
         )
         or
-        op instanceof PostfixCrementOperation
-        or
-        op instanceof PrefixCrementOperation
+        op instanceof CrementOperation
       )
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,7 @@ abstract class LeapYearFieldAccess extends YearFieldAccess {`
`59`	`59`	`(`
`60`	`60`	`op instanceof AssignArithmeticOperation or`
`61`	`61`	`exists(BinaryArithmeticOperation bao \| bao = op.getAnOperand()) or`
`62`		`- op instanceof PostfixCrementOperation or`
`63`		`- op instanceof PrefixCrementOperation`
	`62`	`+ op instanceof CrementOperation`
`64`	`63`	`)`
`65`	`64`	`)`
`66`	`65`	`}`
`@@ -117,9 +116,7 @@ abstract class LeapYearFieldAccess extends YearFieldAccess {`
`117`	`116`	`)`
`118`	`117`	`)`
`119`	`118`	`or`
`120`		`- op instanceof PostfixCrementOperation`
`121`		`- or`
`122`		`- op instanceof PrefixCrementOperation`
	`119`	`+ op instanceof CrementOperation`
`123`	`120`	`)`
`124`	`121`	`)`
`125`	`122`	`}`