Python: Adjust subclass finder to no ESSA nodes

RasmusWL · RasmusWL · commit e050f2e998bb · 2023-12-19T17:07:01.000+01:00
But the new test results looks very strange indeed!
diff --git a/python/ql/lib/semmle/python/frameworks/internal/SubclassFinder.qll b/python/ql/lib/semmle/python/frameworks/internal/SubclassFinder.qll
@@ -199,11 +199,7 @@ module NotExposed {
       relevantClass = newOrExistingModeling(spec).getASubclass*() and
       ImportResolution::module_export(mod, relevantName, def) and
       value = relevantClass.getAValueReachableFromSource().asCfgNode() and
-      (
-        value = def.asVar().getDefinition().(AssignmentDefinition).getValue()
-        or
-        value = def.asCfgNode()
-      )
+      value = def.asCfgNode()
       // value could be a ClassExpr if a new class is defined, or a Name if defining an alias
     ) and
     (
diff --git a/python/ql/test/experimental/library-tests/FindSubclass/Find.expected b/python/ql/test/experimental/library-tests/FindSubclass/Find.expected
@@ -1,3 +1,7 @@
+| Django.Views.View~Subclass | find_subclass_test | Member[ViewAliasInExcept] |
+| Django.Views.View~Subclass | find_subclass_test | Member[ViewAliasInTry] |
+| Django.Views.View~Subclass | find_subclass_test | Member[__name__] |
+| Django.Views.View~Subclass | find_subclass_test | Member[__package__] |
 | Django.Views.View~Subclass | find_subclass_test | Member[clash2] |
 | Django.Views.View~Subclass | find_subclass_test | Member[clash3] |
 | Django.Views.View~Subclass | find_subclass_test | Member[clash] |
@@ -9,6 +13,8 @@
 | flask.View~Subclass | find_subclass_test | Member[ViewAlias] |
 | flask.View~Subclass | find_subclass_test | Member[ViewAlias_no_use] |
 | flask.View~Subclass | find_subclass_test | Member[View] |
+| flask.View~Subclass | find_subclass_test | Member[__name__] |
+| flask.View~Subclass | find_subclass_test | Member[__package__] |
 | flask.View~Subclass | find_subclass_test | Member[clash2] |
 | flask.View~Subclass | find_subclass_test | Member[clash3] |
 | flask.View~Subclass | find_subclass_test | Member[clash] |
