JS: Benign test updates

asgerf · asgerf · commit e0ca1b04820e · 2024-09-10T13:07:24.000+02:00
diff --git a/javascript/ql/test/library-tests/Arrays/DataFlow.expected b/javascript/ql/test/library-tests/Arrays/DataFlow.expected
@@ -1,11 +1,13 @@
 legacyDataFlowDifference
+| arrays.js:2:16:2:23 | "source" | arrays.js:58:8:58:13 | arr[0] | only flow with NEW data flow library |
 flow
 | arrays.js:2:16:2:23 | "source" | arrays.js:5:8:5:14 | obj.foo |
 | arrays.js:2:16:2:23 | "source" | arrays.js:11:10:11:15 | arr[i] |
 | arrays.js:2:16:2:23 | "source" | arrays.js:15:27:15:27 | e |
 | arrays.js:2:16:2:23 | "source" | arrays.js:16:23:16:23 | e |
 | arrays.js:2:16:2:23 | "source" | arrays.js:20:8:20:16 | arr.pop() |
 | arrays.js:2:16:2:23 | "source" | arrays.js:39:8:39:24 | arr4_spread.pop() |
+| arrays.js:2:16:2:23 | "source" | arrays.js:58:8:58:13 | arr[0] |
 | arrays.js:2:16:2:23 | "source" | arrays.js:61:10:61:10 | x |
 | arrays.js:2:16:2:23 | "source" | arrays.js:65:10:65:10 | x |
 | arrays.js:2:16:2:23 | "source" | arrays.js:69:10:69:10 | x |
diff --git a/javascript/ql/test/library-tests/Arrays/arrays.js b/javascript/ql/test/library-tests/Arrays/arrays.js
@@ -55,7 +55,7 @@
     sink(ary); // OK - its the array itself, not an element.
   });
 
-  sink(arr[0]); // OK - tuple like usage.
+  sink(arr[0]); // NOT OK
 
   for (const x of arr) {
     sink(x); // NOT OK
diff --git a/javascript/ql/test/library-tests/FlowSummary/tst.js b/javascript/ql/test/library-tests/FlowSummary/tst.js
@@ -28,7 +28,7 @@ function m3() {
 function m4() {
   const flowIntoArrayElement = mkSummary("Argument[0]", "ReturnValue.ArrayElement");
   sink(flowIntoArrayElement(source()).pop()); // NOT OK
-  sink(flowIntoArrayElement(source())[0]); // NOT OK [INCONSISTENCY]
+  sink(flowIntoArrayElement(source())[0]); // NOT OK
   sink(flowIntoArrayElement(source())[Math.random()]); // NOT OK
   sink(flowIntoArrayElement(source()).prop); // OK
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ function m3() {`
`28`	`28`	`function m4() {`
`29`	`29`	`const flowIntoArrayElement = mkSummary("Argument[0]", "ReturnValue.ArrayElement");`
`30`	`30`	`sink(flowIntoArrayElement(source()).pop()); // NOT OK`
`31`		`- sink(flowIntoArrayElement(source())[0]); // NOT OK [INCONSISTENCY]`
	`31`	`+ sink(flowIntoArrayElement(source())[0]); // NOT OK`
`32`	`32`	`sink(flowIntoArrayElement(source())[Math.random()]); // NOT OK`
`33`	`33`	`sink(flowIntoArrayElement(source()).prop); // OK`
`34`	`34`	`}`