JS: Fix accidental recursion

asgerf · asgerf · commit e2cbf47b16b3 · 2022-02-21T08:16:53.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/data/internal/Impl.qll b/javascript/ql/lib/semmle/javascript/frameworks/data/internal/Impl.qll
@@ -29,7 +29,7 @@ predicate isPackageUsed(string package) {
   or
   package = "global"
   or
-  exists(API::Node::ofType(package, _))
+  any(DataFlow::SourceNode sn).hasUnderlyingType(package, _)
 }
 
 /** Holds if `global` is a global variable referenced via a the `global` package in a CSV row. */

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ predicate isPackageUsed(string package) {`
`29`	`29`	`or`
`30`	`30`	`package = "global"`
`31`	`31`	`or`
`32`		`- exists(API::Node::ofType(package, _))`
	`32`	`+ any(DataFlow::SourceNode sn).hasUnderlyingType(package, _)`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	/** Holds if `global` is a global variable referenced via a the `global` package in a CSV row. */