Fix code review findings in directives base class

tamasvajk · tamasvajk · commit e450b614648d · 2021-02-04T08:42:38.000+01:00
diff --git a/csharp/ql/src/semmle/code/csharp/Preprocessor.qll b/csharp/ql/src/semmle/code/csharp/Preprocessor.qll
@@ -15,7 +15,7 @@ class PreprocessorDirective extends Element, @preprocessor_directive {
    * Holds if this directive is processed by the preprocessor, such as any directive
    * that is not inside a not taken `BranchDirective`.
    */
-  predicate active() { preprocessor_directive_active(this, 1) }
+  predicate isActive() { preprocessor_directive_active(this, 1) }
 
   override Location getALocation() {
     preprocessor_directive_location(this, result) or preprocessor_directive_assembly(this, result)
diff --git a/csharp/ql/test/library-tests/comments/Directives.ql b/csharp/ql/test/library-tests/comments/Directives.ql
@@ -2,5 +2,5 @@ import csharp
 
 query predicate directives(PreprocessorDirective d, Location l, string isActive) {
   d.getALocation() = l and
-  if d.active() then isActive = "active" else isActive = "inactive"
+  if d.isActive() then isActive = "active" else isActive = "inactive"
 }

Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,5 @@ import csharp`
`2`	`2`
`3`	`3`	`query predicate directives(PreprocessorDirective d, Location l, string isActive) {`
`4`	`4`	`d.getALocation() = l and`
`5`		`- if d.active() then isActive = "active" else isActive = "inactive"`
	`5`	`+ if d.isActive() then isActive = "active" else isActive = "inactive"`
`6`	`6`	`}`