add support for the native-promise-only polyfill

erik-krogh · erik-krogh · commit e467ea2ea6b9 · 2021-06-22T10:30:32.000+02:00
diff --git a/javascript/change-notes/2021-06-18-promises.md b/javascript/change-notes/2021-06-18-promises.md
@@ -5,4 +5,5 @@ lgtm,codescanning
     [promise](https://npmjs.com/package/promise),
     [promise-polyfill](https://npmjs.com/package/promise-polyfill),
     [rsvp](https://npmjs.com/package/rsvp),
-    [es6-promise](https://npmjs.com/package/es6-promise)
+    [es6-promise](https://npmjs.com/package/es6-promise),
+    [native-promise-only](https://npmjs.com/package/native-promise-only)
diff --git a/javascript/ql/src/semmle/javascript/Promises.qll b/javascript/ql/src/semmle/javascript/Promises.qll
@@ -79,6 +79,8 @@ private DataFlow::SourceNode getAPromiseObject() {
   result = DataFlow::moduleImport(["promise-polyfill", "promise-polyfill/src/polyfill"])
   or
   result = DataFlow::moduleMember(["es6-promise", "rsvp"], "Promise")
+  or
+  result = DataFlow::moduleImport("native-promise-only")
 }
 
 /**
diff --git a/javascript/ql/test/library-tests/Promises/promises.js b/javascript/ql/test/library-tests/Promises/promises.js
@@ -113,3 +113,8 @@
   var Promise = require('es6-promise').Promise;
   Promise.resolve(source);
 })();
+
+(function() {
+  var Promise = require('native-promise-only');
+  Promise.resolve(source);
+})();
diff --git a/javascript/ql/test/library-tests/Promises/tests.expected b/javascript/ql/test/library-tests/Promises/tests.expected
@@ -41,6 +41,7 @@ test_ResolvedPromiseDefinition
 | promises.js:106:3:106:26 | Promise ... source) | promises.js:106:20:106:25 | source |
 | promises.js:107:3:107:26 | Promise ... source) | promises.js:107:20:107:25 | source |
 | promises.js:114:3:114:25 | Promise ... source) | promises.js:114:19:114:24 | source |
+| promises.js:119:3:119:25 | Promise ... source) | promises.js:119:19:119:24 | source |
 test_PromiseDefinition_getARejectHandler
 | flow.js:26:2:26:49 | new Pro ... ource)) | flow.js:26:69:26:80 | y => sink(y) |
 | flow.js:32:2:32:49 | new Pro ... ource)) | flow.js:32:57:32:68 | x => sink(x) |
@@ -426,3 +427,5 @@ typetrack
 | promises.js:107:3:107:26 | Promise ... source) | promises.js:107:20:107:25 | source | store $PromiseResolveField$ |
 | promises.js:114:3:114:25 | Promise ... source) | promises.js:114:19:114:24 | source | copy $PromiseResolveField$ |
 | promises.js:114:3:114:25 | Promise ... source) | promises.js:114:19:114:24 | source | store $PromiseResolveField$ |
+| promises.js:119:3:119:25 | Promise ... source) | promises.js:119:19:119:24 | source | copy $PromiseResolveField$ |
+| promises.js:119:3:119:25 | Promise ... source) | promises.js:119:19:119:24 | source | store $PromiseResolveField$ |

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,8 @@ private DataFlow::SourceNode getAPromiseObject() {`
`79`	`79`	`result = DataFlow::moduleImport(["promise-polyfill", "promise-polyfill/src/polyfill"])`
`80`	`80`	`or`
`81`	`81`	`result = DataFlow::moduleMember(["es6-promise", "rsvp"], "Promise")`
	`82`	`+ or`
	`83`	`+ result = DataFlow::moduleImport("native-promise-only")`
`82`	`84`	`}`
`83`	`85`
`84`	`86`	`/**`