C++: Address review.

criemen · criemen · commit e7d995313e33 · 2020-10-30T16:30:57.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/PrintAST.qll b/cpp/ql/src/semmle/code/cpp/PrintAST.qll
@@ -345,13 +345,11 @@ class CastNode extends ConversionNode {
  * A node representing a `StmtExpr`.
  */
 class StmtExprNode extends ExprNode {
-  StmtExpr stmtExpr;
-
-  StmtExprNode() { stmtExpr = expr }
+  override StmtExpr expr;
 
   override ASTNode getChildInternal(int childIndex) {
     childIndex = 0 and
-    result.getAST() = stmtExpr.getStmt()
+    result.getAST() = expr.getStmt()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -345,13 +345,11 @@ class CastNode extends ConversionNode {`
`345`	`345`	* A node representing a `StmtExpr`.
`346`	`346`	`*/`
`347`	`347`	`class StmtExprNode extends ExprNode {`
`348`		`- StmtExpr stmtExpr;`
`349`		`-`
`350`		`- StmtExprNode() { stmtExpr = expr }`
	`348`	`+ override StmtExpr expr;`
`351`	`349`
`352`	`350`	`override ASTNode getChildInternal(int childIndex) {`
`353`	`351`	`childIndex = 0 and`
`354`		`- result.getAST() = stmtExpr.getStmt()`
	`352`	`+ result.getAST() = expr.getStmt()`
`355`	`353`	`}`
`356`	`354`	`}`
`357`	`355`