Update to new MethodCall name

egregius313 · egregius313 · commit e9ca4a25d4ad · 2023-12-11T11:18:39.000-05:00
diff --git a/java/ql/lib/semmle/code/java/security/WeakRandomnessQuery.qll b/java/ql/lib/semmle/code/java/security/WeakRandomnessQuery.qll
@@ -51,10 +51,10 @@ abstract class WeakRandomnessSink extends DataFlow::Node { }
 private class CookieSink extends WeakRandomnessSink {
   CookieSink() {
     this.getType() instanceof TypeCookie and
-    exists(MethodAccess ma |
-      ma.getMethod().hasQualifiedName("javax.servlet.http", "HttpServletResponse", "addCookie")
+    exists(MethodCall mc |
+      mc.getMethod().hasQualifiedName("javax.servlet.http", "HttpServletResponse", "addCookie")
     |
-      ma.getArgument(0) = this.asExpr()
+      mc.getArgument(0) = this.asExpr()
     )
   }
 }
@@ -71,7 +71,7 @@ private class CredentialsSink extends WeakRandomnessSink instanceof CredentialsS
 private predicate covertsBytesToString(DataFlow::Node bytes, DataFlow::Node str) {
   bytes.getType().(Array).getElementType().(PrimitiveType).hasName("byte") and
   str.getType() instanceof TypeString and
-  exists(MethodAccess ma | ma = str.asExpr() | bytes.asExpr() = ma.getAnArgument())
+  exists(MethodCall mc | mc = str.asExpr() | bytes.asExpr() = mc.getAnArgument())
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,10 @@ abstract class WeakRandomnessSink extends DataFlow::Node { }`
`51`	`51`	`private class CookieSink extends WeakRandomnessSink {`
`52`	`52`	`CookieSink() {`
`53`	`53`	`this.getType() instanceof TypeCookie and`
`54`		`- exists(MethodAccess ma \|`
`55`		`- ma.getMethod().hasQualifiedName("javax.servlet.http", "HttpServletResponse", "addCookie")`
	`54`	`+ exists(MethodCall mc \|`
	`55`	`+ mc.getMethod().hasQualifiedName("javax.servlet.http", "HttpServletResponse", "addCookie")`
`56`	`56`	`\|`
`57`		`- ma.getArgument(0) = this.asExpr()`
	`57`	`+ mc.getArgument(0) = this.asExpr()`
`58`	`58`	`)`
`59`	`59`	`}`
`60`	`60`	`}`
`@@ -71,7 +71,7 @@ private class CredentialsSink extends WeakRandomnessSink instanceof CredentialsS`
`71`	`71`	`private predicate covertsBytesToString(DataFlow::Node bytes, DataFlow::Node str) {`
`72`	`72`	`bytes.getType().(Array).getElementType().(PrimitiveType).hasName("byte") and`
`73`	`73`	`str.getType() instanceof TypeString and`
`74`		`- exists(MethodAccess ma \| ma = str.asExpr() \| bytes.asExpr() = ma.getAnArgument())`
	`74`	`+ exists(MethodCall mc \| mc = str.asExpr() \| bytes.asExpr() = mc.getAnArgument())`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`/**`