Merge pull request #13038 from owen-mc/go/downgrade-package-not-found-diagnostic-to-warning

owen-mc · web-flow · commit edeffd888569 · 2023-05-10T11:24:37.000+01:00
Go: Downgrade go/autobuilder/package-not-found diagnostic to warning
diff --git a/go/extractor/diagnostics/diagnostics.go b/go/extractor/diagnostics/diagnostics.go
@@ -155,7 +155,7 @@ func EmitCannotFindPackages(pkgPaths []string) {
 		"go/autobuilder/package-not-found",
 		"Some packages could not be found",
 		fmt.Sprintf("%d package%s could not be found.\n\n%s.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).", numPkgPaths, ending, secondLine),
-		severityError,
+		severityWarning,
 		fullVisibility,
 		noLocation,
 	)
diff --git a/go/ql/integration-tests/all-platforms/go/diagnostics/package-not-found-with-go-mod/diagnostics.expected b/go/ql/integration-tests/all-platforms/go/diagnostics/package-not-found-with-go-mod/diagnostics.expected
@@ -1,6 +1,6 @@
 {
   "markdownMessage": "110 packages could not be found.\n\n`github.com/nosuchorg/nosuchrepo000`, `github.com/nosuchorg/nosuchrepo001`, `github.com/nosuchorg/nosuchrepo002`, `github.com/nosuchorg/nosuchrepo003`, `github.com/nosuchorg/nosuchrepo004` and 105 more.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).",
-  "severity": "error",
+  "severity": "warning",
   "source": {
     "extractorName": "go",
     "id": "go/autobuilder/package-not-found",
diff --git a/go/ql/integration-tests/all-platforms/go/diagnostics/package-not-found-without-go-mod/diagnostics.expected b/go/ql/integration-tests/all-platforms/go/diagnostics/package-not-found-without-go-mod/diagnostics.expected
@@ -1,6 +1,6 @@
 {
   "markdownMessage": "1 package could not be found.\n\n`github.com/linode/linode-docs-theme`.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).",
-  "severity": "error",
+  "severity": "warning",
   "source": {
     "extractorName": "go",
     "id": "go/autobuilder/package-not-found",

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ func EmitCannotFindPackages(pkgPaths []string) {`
`155`	`155`	`"go/autobuilder/package-not-found",`
`156`	`156`	`"Some packages could not be found",`
`157`	`157`	`fmt.Sprintf("%d package%s could not be found.\n\n%s.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).", numPkgPaths, ending, secondLine),`
`158`		`- severityError,`
	`158`	`+ severityWarning,`
`159`	`159`	`fullVisibility,`
`160`	`160`	`noLocation,`
`161`	`161`	`)`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	"markdownMessage": "110 packages could not be found.\n\n`github.com/nosuchorg/nosuchrepo000`, `github.com/nosuchorg/nosuchrepo001`, `github.com/nosuchorg/nosuchrepo002`, `github.com/nosuchorg/nosuchrepo003`, `github.com/nosuchorg/nosuchrepo004` and 105 more.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).",
`3`		`- "severity": "error",`
	`3`	`+ "severity": "warning",`
`4`	`4`	`"source": {`
`5`	`5`	`"extractorName": "go",`
`6`	`6`	`"id": "go/autobuilder/package-not-found",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	"markdownMessage": "1 package could not be found.\n\n`github.com/linode/linode-docs-theme`.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).",
`3`		`- "severity": "error",`
	`3`	`+ "severity": "warning",`
`4`	`4`	`"source": {`
`5`	`5`	`"extractorName": "go",`
`6`	`6`	`"id": "go/autobuilder/package-not-found",`