Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ef0d372

Browse files
Addressing a few comments
1 parent 190164c commit ef0d372

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

csharp/ql/src/experimental/Security Features/backdoor/PotentialTimeBomb.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"qhelp.dtd">
44
<qhelp>
55
<overview>
6-
<p>This query checks for data flow from a file's last modification date and a condition statement that controls code execution. A malicious actor could have implanted code that triggers after a certain time, leading to a "time bomb".</p>
6+
<p>This query detects situations in which an offset to a last file modification time is used to conditionally execute a particular block of code. This is a common pattern in backdoors, where the file's modification timestamp is the time at which the backdoor was planted, and the time offset is used as a time bomb before a particular code block is executed.</p>
77
</overview>
88

99
<recommendation>

csharp/ql/src/experimental/Security Features/campaign/Solorigate/ModifiedFnvFunctionDetection.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"qhelp.dtd">
44
<qhelp>
55
<overview>
6-
<p>In Solorigate, the malicious code tried to evade various security detection software by comparing hashes of the process names against an embedded list of values. The malicious code included hash values calculated using a standard FNV-1A 64-bit hash with an additional XOR by a literal after computing the FNV-1A.</p>
6+
<p>In Solorigate, the malicious code tried to evade various security detection software by comparing hashes of the process names against an embedded list of values. The malicious code used in the SolarWinds attack included hash values calculated using a standard FNV-1A 64-bit hash with an additional XOR by a literal after computing the FNV-1A.</p>
77
<p>This query detects FNV-like hash calculations where there is an additional XOR (with any static value) after the hash calculation loop.</p>
88
</overview>
99

csharp/ql/src/experimental/Security Features/campaign/Solorigate/NumberOfKnownCommandsAboveThreshold.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @name Number of Solorigate-related command names in enum is above the threshold
3-
* @description The enum contains several values that look similar to command and control command names, which may indicate that the code may have been tampered by an external agent.
3+
* @description The enum contains several values that look similar to command and control command names, which may indicate that the code may have been tampered with by an external agent.
44
* It is recommended to review the code and verify that there is no unexpected code in this project.
55
* @kind problem
66
* @tags security

0 commit comments

Comments
 (0)