spelling: arithmetic

jsoref · jsoref · commit ef63f57e55fa · 2022-10-13T19:45:25.000-04:00
Signed-off-by: Josh Soref &lt;2119212+jsoref@users.noreply.github.com&gt;
diff --git a/csharp/ql/lib/semmle/code/csharp/exprs/Expr.qll b/csharp/ql/lib/semmle/code/csharp/exprs/Expr.qll
@@ -192,7 +192,7 @@ class Operation extends Expr, @op_expr {
 }
 
 /**
- * A unary operation. Either a unary arithemtic operation
+ * A unary operation. Either a unary arithmetic operation
  * (`UnaryArithmeticOperation`), a unary bitwise operation
  * (`UnaryBitwiseOperation`), a `sizeof` operation (`SizeofExpr`), a pointer
  * indirection operation (`PointerIndirectionExpr`), an address-of operation
@@ -206,7 +206,7 @@ class UnaryOperation extends Operation, @un_op {
 }
 
 /**
- * A binary operation. Either a binary arithemtic operation
+ * A binary operation. Either a binary arithmetic operation
  * (`BinaryArithmeticOperation`), a binary bitwise operation
  * (`BinaryBitwiseOperation`), a comparison operation (`ComparisonOperation`),
  * or a binary logical operation (`BinaryLogicalOperation`).
diff --git a/csharp/ql/src/experimental/Security Features/backdoor/PotentialTimeBomb.ql b/csharp/ql/src/experimental/Security Features/backdoor/PotentialTimeBomb.ql
@@ -61,7 +61,7 @@ class DateTimeStruct extends Struct {
   /**
    * holds if the Callable is used for DateTime arithmetic operations
    */
-  Callable getATimeSpanArtithmeticCallable() {
+  Callable getATimeSpanArithmeticCallable() {
     (result = this.getAnOperator() or result = this.getAMethod()) and
     result.getName() in [
         "Add", "AddDays", "AddHours", "AddMilliseconds", "AddMinutes", "AddMonths", "AddSeconds",
@@ -96,7 +96,7 @@ private class FlowsFromGetLastWriteTimeConfigToTimeSpanArithmeticCallable extend
   override predicate isSink(DataFlow::Node sink) {
     exists(Call call, DateTimeStruct dateTime |
       call.getAChild*() = sink.asExpr() and
-      call = dateTime.getATimeSpanArtithmeticCallable().getACall()
+      call = dateTime.getATimeSpanArithmeticCallable().getACall()
     )
   }
 }
@@ -111,7 +111,7 @@ private class FlowsFromTimeSpanArithmeticToTimeComparisonCallable extends TaintT
 
   override predicate isSource(DataFlow::Node source) {
     exists(DateTimeStruct dateTime, Call call | source.asExpr() = call |
-      call = dateTime.getATimeSpanArtithmeticCallable().getACall()
+      call = dateTime.getATimeSpanArithmeticCallable().getACall()
     )
   }
 
@@ -157,7 +157,7 @@ predicate isPotentialTimeBomb(
   |
     pathSource.getNode() = exprNode(getLastWriteTimeMethodCall) and
     config1.hasFlow(exprNode(getLastWriteTimeMethodCall), sink) and
-    timeArithmeticCall = dateTime.getATimeSpanArtithmeticCallable().getACall() and
+    timeArithmeticCall = dateTime.getATimeSpanArithmeticCallable().getACall() and
     timeArithmeticCall.getAChild*() = sink.asExpr() and
     config2.hasFlow(exprNode(timeArithmeticCall), sink2) and
     timeComparisonCall = dateTime.getAComparisonCallable().getACall() and

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class DateTimeStruct extends Struct {`
`61`	`61`	`/**`
`62`	`62`	`* holds if the Callable is used for DateTime arithmetic operations`
`63`	`63`	`*/`
`64`		`- Callable getATimeSpanArtithmeticCallable() {`
	`64`	`+ Callable getATimeSpanArithmeticCallable() {`
`65`	`65`	`(result = this.getAnOperator() or result = this.getAMethod()) and`
`66`	`66`	`result.getName() in [`
`67`	`67`	`"Add", "AddDays", "AddHours", "AddMilliseconds", "AddMinutes", "AddMonths", "AddSeconds",`
`@@ -96,7 +96,7 @@ private class FlowsFromGetLastWriteTimeConfigToTimeSpanArithmeticCallable extend`
`96`	`96`	`override predicate isSink(DataFlow::Node sink) {`
`97`	`97`	`exists(Call call, DateTimeStruct dateTime \|`
`98`	`98`	`call.getAChild*() = sink.asExpr() and`
`99`		`- call = dateTime.getATimeSpanArtithmeticCallable().getACall()`
	`99`	`+ call = dateTime.getATimeSpanArithmeticCallable().getACall()`
`100`	`100`	`)`
`101`	`101`	`}`
`102`	`102`	`}`
`@@ -111,7 +111,7 @@ private class FlowsFromTimeSpanArithmeticToTimeComparisonCallable extends TaintT`
`111`	`111`
`112`	`112`	`override predicate isSource(DataFlow::Node source) {`
`113`	`113`	`exists(DateTimeStruct dateTime, Call call \| source.asExpr() = call \|`
`114`		`- call = dateTime.getATimeSpanArtithmeticCallable().getACall()`
	`114`	`+ call = dateTime.getATimeSpanArithmeticCallable().getACall()`
`115`	`115`	`)`
`116`	`116`	`}`
`117`	`117`
`@@ -157,7 +157,7 @@ predicate isPotentialTimeBomb(`
`157`	`157`	`\|`
`158`	`158`	`pathSource.getNode() = exprNode(getLastWriteTimeMethodCall) and`
`159`	`159`	`config1.hasFlow(exprNode(getLastWriteTimeMethodCall), sink) and`
`160`		`- timeArithmeticCall = dateTime.getATimeSpanArtithmeticCallable().getACall() and`
	`160`	`+ timeArithmeticCall = dateTime.getATimeSpanArithmeticCallable().getACall() and`
`161`	`161`	`timeArithmeticCall.getAChild*() = sink.asExpr() and`
`162`	`162`	`config2.hasFlow(exprNode(timeArithmeticCall), sink2) and`
`163`	`163`	`timeComparisonCall = dateTime.getAComparisonCallable().getACall() and`