C++: Added charpred to ensure that only instructions that have a source representation have a GVN

MathiasVP · MathiasVP · commit ef89e3bdb582 · 2020-02-06T15:43:57.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/ASTValueNumbering.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/ASTValueNumbering.qll
@@ -51,6 +51,12 @@ private import semmle.code.cpp.ir.IR
  * methods.
  */
 class GVN extends TValueNumber {
+  GVN() {
+    exists(Instruction instr |
+      this = tvalueNumber(instr) and exists(instr.getUnconvertedResultExpression())
+    )
+  }
+
   private Instruction getAnInstruction() { this = tvalueNumber(result) }
 
   final string toString() { result = "GVN" }
