Python: Model fabric task decorator (version 2.x)

RasmusWL · RasmusWL · commit f10456e35fe2 · 2020-10-19T18:03:03.000+02:00
diff --git a/python/ql/src/experimental/semmle/python/frameworks/Fabric.qll b/python/ql/src/experimental/semmle/python/frameworks/Fabric.qll
@@ -357,5 +357,42 @@ private module FabricV2 {
         result.asCfgNode() = [node.getArg(0), node.getArgByName("command")]
       }
     }
+
+    // -------------------------------------------------------------------------
+    // fabric.tasks
+    // -------------------------------------------------------------------------
+    /** Gets a reference to the `fabric.tasks` module. */
+    DataFlow::Node tasks() { result = fabric_attr("tasks") }
+
+    /** Provides models for the `fabric.tasks` module */
+    module tasks {
+      /** Gets a reference to the `fabric.tasks.task` decorator. */
+      private DataFlow::Node task(DataFlow::TypeTracker t) {
+        t.start() and
+        result = DataFlow::importNode("fabric.tasks.task")
+        or
+        t.startInAttr("task") and
+        result = tasks()
+        or
+        // Handle `fabric.task` alias
+        t.startInAttr("task") and
+        result = fabric()
+        or
+        exists(DataFlow::TypeTracker t2 | result = task(t2).track(t2, t))
+      }
+
+      /** Gets a reference to the `fabric.tasks.task` decorator. */
+      DataFlow::Node task() { result = task(DataFlow::TypeTracker::end()) }
+    }
+
+    class FabricTaskFirstParamConnectionInstance extends fabric::connection::Connection::InstanceSource,
+      DataFlow::ParameterNode {
+      FabricTaskFirstParamConnectionInstance() {
+        exists(Function func |
+          func.getADecorator() = fabric::tasks::task().asExpr() and
+          this.getParameter() = func.getArg(0)
+        )
+      }
+    }
   }
 }
diff --git a/python/ql/test/experimental/library-tests/frameworks/fabric/ConceptsTest.expected b/python/ql/test/experimental/library-tests/frameworks/fabric/ConceptsTest.expected
@@ -4,5 +4,3 @@
 | fabric_v2_test.py:41:69:41:94 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
 | fabric_v2_test.py:44:25:44:50 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
 | fabric_v2_test.py:47:65:47:90 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
-| fabric_v2_test.py:58:26:58:51 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
-| fabric_v2_test.py:64:26:64:51 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
