JS: use HTML::ScriptElement::getScript in Vue

Esben Sparre Andreasen · Esben Sparre Andreasen · commit f15af70c0279 · 2019-02-06T09:38:00.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Vue.qll b/javascript/ql/src/semmle/javascript/frameworks/Vue.qll
@@ -333,13 +333,8 @@ module Vue {
     }
 
     private Module getModule() {
-      exists(HTML::ScriptElement script | script.getFile() = file |
-        result.getTopLevel() = script.resolveSource()
-        or
-        not exists(script.getSourcePath()) and
-        // XXX is there no way explicit relation between a script tag and its inline script?
-        result.getTopLevel() instanceof InlineScript and
-        result.getFile() = script.getFile()
+      exists(HTML::ScriptElement elem | elem.getFile() = file |
+        result.getTopLevel() = elem.getScript()
       )
     }
 

Original file line number	Diff line number	Diff line change
`@@ -333,13 +333,8 @@ module Vue {`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`private Module getModule() {`
`336`		`- exists(HTML::ScriptElement script \| script.getFile() = file \|`
`337`		`- result.getTopLevel() = script.resolveSource()`
`338`		`- or`
`339`		`- not exists(script.getSourcePath()) and`
`340`		`- // XXX is there no way explicit relation between a script tag and its inline script?`
`341`		`- result.getTopLevel() instanceof InlineScript and`
`342`		`- result.getFile() = script.getFile()`
	`336`	`+ exists(HTML::ScriptElement elem \| elem.getFile() = file \|`
	`337`	`+ result.getTopLevel() = elem.getScript()`
`343`	`338`	`)`
`344`	`339`	`}`
`345`	`340`