Python: Add clarifying comment and pragma.

markshannon · markshannon · commit f29dfa5112f7 · 2019-06-14T16:57:32.000+01:00
diff --git a/python/ql/src/semmle/python/Pruning.qll b/python/ql/src/semmle/python/Pruning.qll
@@ -548,7 +548,8 @@ module Pruner {
         simply_dead(pred, succ)
     }
 
-    /* Helper for `unreachableEdge` */
+    /* Helper for `unreachableEdge`, deal with inequalities here to avoid blow up */
+    pragma [inline]
     private predicate contradicts(Constraint a, Constraint b) {
         a.contradicts(b) or
         a.(ConstrainedByConstant).minValue() > b.(ConstrainedByConstant).maxValue() or

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,8 @@ module Pruner {`
`548`	`548`	`simply_dead(pred, succ)`
`549`	`549`	`}`
`550`	`550`
`551`		- /* Helper for `unreachableEdge` */
	`551`	+ /* Helper for `unreachableEdge`, deal with inequalities here to avoid blow up */
	`552`	`+ pragma [inline]`
`552`	`553`	`private predicate contradicts(Constraint a, Constraint b) {`
`553`	`554`	`a.contradicts(b) or`
`554`	`555`	`a.(ConstrainedByConstant).minValue() > b.(ConstrainedByConstant).maxValue() or`