Var only used in one side of disjunct

maikypedia · maikypedia · commit f46620c455b7 · 2023-05-15T15:09:44.000+02:00
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/Mysql2.qll b/ruby/ql/lib/codeql/ruby/frameworks/Mysql2.qll
@@ -35,12 +35,14 @@ module Mysql2 {
     private DataFlow::Node query;
 
     Mysql2Execution() {
-      exists(Mysql2Connection mysql2Connection, DataFlow::CallNode prepareCall |
+      exists(Mysql2Connection mysql2Connection |
         this = mysql2Connection.getAMethodCall("query") and query = this.getArgument(0)
         or
-        prepareCall = mysql2Connection.getAMethodCall("prepare") and
-        query = prepareCall.getArgument(0) and
-        this = prepareCall.getAMethodCall("execute")
+        exists(DataFlow::CallNode prepareCall |
+          prepareCall = mysql2Connection.getAMethodCall("prepare") and
+          query = prepareCall.getArgument(0) and
+          this = prepareCall.getAMethodCall("execute")
+        )
       )
     }
 
