[CPP-370] Remove prohibition against UserDefinedFormattingFunction

zlaski-semmle · zlaski-semmle · commit f6903c769af9 · 2019-05-21T06:21:12.000-07:00
diff --git a/cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql b/cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
@@ -97,11 +97,7 @@ class NonConstFlow extends TaintTracking::Configuration {
   override predicate isSource(DataFlow::Node source) { isNonConst(source) }
 
   override predicate isSink(DataFlow::Node sink) {
-    exists(FormattingFunctionCall fc |
-      sink.asExpr() = fc.getArgument(fc.getFormatParameterIndex())
-    |
-      not fc.getTarget() instanceof UserDefinedFormattingFunction
-    )
+    exists(FormattingFunctionCall fc | sink.asExpr() = fc.getArgument(fc.getFormatParameterIndex()))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -97,11 +97,7 @@ class NonConstFlow extends TaintTracking::Configuration {`
`97`	`97`	`override predicate isSource(DataFlow::Node source) { isNonConst(source) }`
`98`	`98`
`99`	`99`	`override predicate isSink(DataFlow::Node sink) {`
`100`		`- exists(FormattingFunctionCall fc \|`
`101`		`- sink.asExpr() = fc.getArgument(fc.getFormatParameterIndex())`
`102`		`- \|`
`103`		`- not fc.getTarget() instanceof UserDefinedFormattingFunction`
`104`		`- )`
	`100`	`+ exists(FormattingFunctionCall fc \| sink.asExpr() = fc.getArgument(fc.getFormatParameterIndex()))`
`105`	`101`	`}`
`106`	`102`	`}`
`107`	`103`