JS: fixups

esbena · esbena · commit fa4e8914e660 · 2020-06-18T13:00:45.000+02:00
diff --git a/javascript/ql/src/Security/CWE-770/MemoryExhaustion.ql b/javascript/ql/src/Security/CWE-770/MemoryExhaustion.ql
@@ -96,7 +96,7 @@ class Configuration extends TaintTracking::Configuration {
           c = dst and
           src = c.getAnArgument()
         |
-          c = DataFlow::globalVarRef("Math").getAPropertyRead().getACall() or
+          c = DataFlow::globalVarRef("Math").getAMemberCall(_) or
           c = DataFlow::globalVarRef(["Number", "parseInt", "parseFloat"]).getACall()
         )
       )
@@ -191,10 +191,12 @@ class BufferSizeSink extends Sink {
       )
       or
       invk = clazz.getAnInvocation() and
-      invk.getNumArgument() = 1 and
-      index = 0
-      or
-      invk.getNumArgument() = 3 and index = 2
+      (
+        invk.getNumArgument() = 1 and
+        index = 0
+        or
+        invk.getNumArgument() = 3 and index = 2
+      )
     )
     or
     this = DataFlow::globalVarRef("SlowBuffer").getAnInstantiation().getArgument(0)

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ class Configuration extends TaintTracking::Configuration {`
`96`	`96`	`c = dst and`
`97`	`97`	`src = c.getAnArgument()`
`98`	`98`	`\|`
`99`		`- c = DataFlow::globalVarRef("Math").getAPropertyRead().getACall() or`
	`99`	`+ c = DataFlow::globalVarRef("Math").getAMemberCall(_) or`
`100`	`100`	`c = DataFlow::globalVarRef(["Number", "parseInt", "parseFloat"]).getACall()`
`101`	`101`	`)`
`102`	`102`	`)`
`@@ -191,10 +191,12 @@ class BufferSizeSink extends Sink {`
`191`	`191`	`)`
`192`	`192`	`or`
`193`	`193`	`invk = clazz.getAnInvocation() and`
`194`		`- invk.getNumArgument() = 1 and`
`195`		`- index = 0`
`196`		`- or`
`197`		`- invk.getNumArgument() = 3 and index = 2`
	`194`	`+ (`
	`195`	`+ invk.getNumArgument() = 1 and`
	`196`	`+ index = 0`
	`197`	`+ or`
	`198`	`+ invk.getNumArgument() = 3 and index = 2`
	`199`	`+ )`
`198`	`200`	`)`
`199`	`201`	`or`
`200`	`202`	`this = DataFlow::globalVarRef("SlowBuffer").getAnInstantiation().getArgument(0)`