Merge pull request #1357 from asger-semmle/jump-to-namespace

semmle-qlci · web-flow · commit fac620d6f3fd · 2019-05-23T09:00:24.000+01:00
Approved by xiemaisi
diff --git a/javascript/ql/src/definitions.ql b/javascript/ql/src/definitions.ql
@@ -123,20 +123,14 @@ predicate propertyLookup(Expr prop, ASTNode write, string kind) {
 }
 
 /**
- * Holds if `ref` is an identifier that refers to a type or namespace declared at `decl`.
+ * Holds if `ref` is an identifier that refers to a type declared at `decl`.
  */
 predicate typeLookup(ASTNode ref, ASTNode decl, string kind) {
   exists(TypeAccess typeAccess |
     ref = typeAccess.getIdentifier() and
     decl = typeAccess.getTypeName().getADefinition() and
     kind = "T"
   )
-  or
-  exists(NamespaceAccess namespaceAccess |
-    ref = namespaceAccess.getIdentifier() and
-    decl = namespaceAccess.getNamespace().getADefinition() and
-    kind = "T"
-  )
 }
 
 /**
diff --git a/javascript/ql/test/query-tests/definitions/definitions.expected b/javascript/ql/test/query-tests/definitions/definitions.expected
@@ -5,11 +5,9 @@
 | client.ts:7:19:7:19 | C | tslib.ts:1:8:3:1 | class C {\\n  m() {}\\n} | T |
 | client.ts:8:10:8:10 | C | client.ts:3:1:5:1 | class C {\\n  m() {}\\n} | T |
 | client.ts:9:16:9:16 | C | client.ts:3:1:5:1 | class C {\\n  m() {}\\n} | T |
-| client.ts:10:14:10:14 | N | tslib.ts:5:8:9:1 | namespa ... }\\n  }\\n} | T |
 | client.ts:10:16:10:16 | C | tslib.ts:6:10:8:3 | class C ...  {}\\n  } | T |
 | client.ts:13:25:13:25 | C | client.ts:3:1:5:1 | class C {\\n  m() {}\\n} | T |
 | client.ts:13:35:13:35 | C | tslib.ts:1:8:3:1 | class C {\\n  m() {}\\n} | T |
-| client.ts:13:45:13:45 | N | tslib.ts:5:8:9:1 | namespa ... }\\n  }\\n} | T |
 | client.ts:13:47:13:47 | C | tslib.ts:6:10:8:3 | class C ...  {}\\n  } | T |
 | client.ts:14:3:14:3 | x | client.ts:13:22:13:22 | x | V |
 | client.ts:14:5:14:5 | m | client.ts:4:3:4:8 | m() {} | M |
