C++: Minimal caching of the IR type system

jbj · jbj · commit fb4dac597c81 · 2019-11-03T16:40:30.000+01:00
This was the minimal amount of predicates I could easily cache without
introducing extra cached stages. The predicates that are not cached
here, like `CppType::getTypeSize` and `getCanonicalLanguageType`, appear
to be cheap.

I've tested that this avoids recomputation of the IR type system by
running

    grep -c 'Starting to evaluate predicate CppType::CppType::getIRType_dispred'

on the evaluator log for `IRSanity.ql`. It drops from 4 to 1. The
pretty-printed DIL drops from 79,175 lines to 76,326 lines.
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/IRType.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/IRType.qll
@@ -4,6 +4,7 @@
 
 private import internal.IRTypeInternal
 
+cached
 private newtype TIRType =
   TIRVoidType() or
   TIRUnknownType() or
diff --git a/cpp/ql/src/semmle/code/cpp/ir/internal/CppType.qll b/cpp/ql/src/semmle/code/cpp/ir/internal/CppType.qll
@@ -175,6 +175,7 @@ private IRType getIRTypeForPRValue(Type type) {
   )
 }
 
+cached
 private newtype TCppType =
   TPRValueType(Type type) { exists(getIRTypeForPRValue(type)) } or
   TFunctionGLValueType() or
@@ -203,6 +204,7 @@ class CppType extends TCppType {
    * Gets the `IRType` that represents this `CppType`. Many different `CppType`s can map to a single
    * `IRType`.
    */
+  cached
   IRType getIRType() { none() }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -175,6 +175,7 @@ private IRType getIRTypeForPRValue(Type type) {`
`175`	`175`	`)`
`176`	`176`	`}`
`177`	`177`
	`178`	`+cached`
`178`	`179`	`private newtype TCppType =`
`179`	`180`	`TPRValueType(Type type) { exists(getIRTypeForPRValue(type)) } or`
`180`	`181`	`TFunctionGLValueType() or`
`@@ -203,6 +204,7 @@ class CppType extends TCppType {`
`203`	`204`	* Gets the `IRType` that represents this `CppType`. Many different `CppType`s can map to a single
`204`	`205`	* `IRType`.
`205`	`206`	`*/`
	`207`	`+ cached`
`206`	`208`	`IRType getIRType() { none() }`
`207`	`209`
`208`	`210`	`/**`